From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28424 invoked by alias); 9 Mar 2009 21:22:40 -0000 Received: (qmail 28416 invoked by uid 22791); 9 Mar 2009 21:22:39 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Mar 2009 21:22:34 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D000F10D9A; Mon, 9 Mar 2009 21:22:31 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 759A310B26; Mon, 9 Mar 2009 21:22:31 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Lgmve-0004aO-KC; Mon, 09 Mar 2009 17:22:30 -0400 Date: Mon, 09 Mar 2009 21:22:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com, Nick Roberts Subject: Re: [RFC] Fix MI timings Message-ID: <20090309212230.GA17609@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com, Nick Roberts References: <200903100010.06180.vladimir@codesourcery.com> <200903100015.03600.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200903100015.03600.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00128.txt.bz2 On Tue, Mar 10, 2009 at 12:15:03AM +0300, Vladimir Prus wrote: > *This* patch. You must've been working on programs in some Other Real Language lately... :-) > @@ -97,6 +97,8 @@ static void timestamp (struct mi_timestamp *tv); > > static void print_diff_now (struct mi_timestamp *start); > static void print_diff (struct mi_timestamp *start, struct mi_timestamp *end); > +void print_timing_maybe (); > + > > void > mi_cmd_gdb_exit (char *command, char **argv, int argc) Prototypes in .h files only please. > @@ -1567,6 +1561,15 @@ print_diff_now (struct mi_timestamp *start) > print_diff (start, &now); > } > > +void > +print_timing_maybe () (void) > +{ > + // If the command is -enable-timing then do_timings may be > + // true whilst current_command_ts is not initialized. /* */ > +void print_timing_maybe (); (void) Also, since this is public, please give it an "mi_" prefix. I have nothing useful to say about the important part of the patch, though. -- Daniel Jacobowitz CodeSourcery