From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23847 invoked by alias); 9 Mar 2009 18:41:49 -0000 Received: (qmail 23839 invoked by uid 22791); 9 Mar 2009 18:41:49 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Mar 2009 18:41:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0D8592BE8CE; Mon, 9 Mar 2009 14:41:45 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8Ns2CvDwpGG9; Mon, 9 Mar 2009 14:41:44 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 9710B2BE8CB; Mon, 9 Mar 2009 14:41:44 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id EE511E7940; Mon, 9 Mar 2009 11:41:38 -0700 (PDT) Date: Mon, 09 Mar 2009 18:41:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch] Correct `gcc -D' macros get ignored (PR 9873) Message-ID: <20090309184138.GB4561@adacore.com> References: <20090219214540.GA32244@host0.dyn.jankratochvil.net> <20090228071514.GA25299@adacore.com> <20090228100225.GA15788@host0.dyn.jankratochvil.net> <20090303005430.GL26056@adacore.com> <20090309005707.GB29150@host0.dyn.jankratochvil.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090309005707.GB29150@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00118.txt.bz2 > 2009-03-09 Jan Kratochvil > > PR gdb/9873: > * dwarf2read.c (dwarf_decode_macros): New variable `at_commandline'. > Move the variable `macinfo_type' out of the loop. Create a new > processing pass before the current one to pre-create `current_file'. > New complaint on misplaced zero/non-zero definitions/includes. > Skip first DW_MACINFO_start_file with `at_commandline' set. This is OK, with one tiny typo (and I'm probably the one responsible for it). > Sure I find your text better although its first line does not follow the GNU > Coding Style directive `[...] please write complete sentences [...]'. > Used your text. Are you refering to the "First pass:"? I think it's OK. > OK although it was catching both inconsistencies so it has to be written as > > if ((line == 0 && !at_commandline) || (line != 0 && at_commandline)) Right! > + associated to base file. ^^^ "the" base file... Cheers, -- Joel