From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15150 invoked by alias); 9 Mar 2009 18:33:27 -0000 Received: (qmail 15128 invoked by uid 22791); 9 Mar 2009 18:33:27 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Mar 2009 18:33:20 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CE6422BE703; Mon, 9 Mar 2009 14:33:22 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id AkBxKpl95IdZ; Mon, 9 Mar 2009 14:33:22 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 93DDA2BE701; Mon, 9 Mar 2009 14:33:22 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id B6DE4E7940; Mon, 9 Mar 2009 11:33:16 -0700 (PDT) Date: Mon, 09 Mar 2009 18:33:00 -0000 From: Joel Brobecker To: Paul Pluzhnikov Cc: tromey@redhat.com, Pedro Alves , gdb-patches@sourceware.org Subject: Re: [patch] Fix a crash when displaying variables from shared library. Message-ID: <20090309183316.GA4561@adacore.com> References: <20090223010759.GA30997@adacore.com> <8ac60eac0902231012lb42bcb1q8b8cf19ad2ac192@mail.gmail.com> <8ac60eac0903021830w363783ear7d4c8fc1177d6448@mail.gmail.com> <8ac60eac0903041124s1aafb562u225f268c4d1511dd@mail.gmail.com> <20090305200415.GC3744@adacore.com> <8ac60eac0903051546r1eaffc89tf1f35b21e6dc1b40@mail.gmail.com> <8ac60eac0903051906r5d41990bwcaccdfb4accef562@mail.gmail.com> <20090306174822.GJ3744@adacore.com> <8ac60eac0903061406t610ba1a1y1c62e5ee30332c7c@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ac60eac0903061406t610ba1a1y1c62e5ee30332c7c@mail.gmail.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00116.txt.bz2 > 2009-03-06 Paul Pluzhnikov > > * solib.c (solib_contains_address_p): New function. > (solib_name_from_address): Use it. > * printcmd.c (display_uses_solib_p): Use it. > * solib.h (solib_contains_address_p): Declare it. Looks great to me. Go ahead and check it in. Thanks, -- Joel