From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9841 invoked by alias); 9 Mar 2009 18:22:27 -0000 Received: (qmail 9822 invoked by uid 22791); 9 Mar 2009 18:22:26 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Mar 2009 18:22:20 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n29IMFoj031267 for ; Mon, 9 Mar 2009 14:22:16 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n29IMGFJ020530 for ; Mon, 9 Mar 2009 14:22:16 -0400 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n29IMEVC032767 for ; Mon, 9 Mar 2009 14:22:15 -0400 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id n29IMCMp021766 for ; Mon, 9 Mar 2009 19:22:12 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id n29IMBoo021763 for gdb-patches@sourceware.org; Mon, 9 Mar 2009 19:22:11 +0100 Date: Mon, 09 Mar 2009 18:22:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [patch] Fix a value leak by VAROBJ Message-ID: <20090309182211.GA21666@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00114.txt.bz2 Hi, a memory leak. install_new_value() already release_value()s `var->value'. No regressions on x86_64-unknown-linux-gnu (there is now a recent regression on HEAD for gdb.base/sigbpt.exp but it is unrelated to this patch). Thanks, Jan gdb/ 2009-03-09 Jan Kratochvil * varobj.c (free_variable): Call value_free. --- gdb/varobj.c 5 Feb 2009 17:28:21 -0000 1.123 +++ gdb/varobj.c 9 Mar 2009 17:35:49 -0000 @@ -1512,6 +1512,8 @@ new_root_variable (void) static void free_variable (struct varobj *var) { + value_free (var->value); + /* Free the expression if this is a root variable. */ if (is_root_p (var)) {