From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17307 invoked by alias); 6 Mar 2009 18:47:02 -0000 Received: (qmail 17291 invoked by uid 22791); 6 Mar 2009 18:47:01 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 06 Mar 2009 18:46:56 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 51CA82BABA0; Fri, 6 Mar 2009 13:46:58 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id XISayKx+eOny; Fri, 6 Mar 2009 13:46:58 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 02A8B2BAB9C; Fri, 6 Mar 2009 13:46:58 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 2E0BFE7ACD; Fri, 6 Mar 2009 10:46:52 -0800 (PST) Date: Fri, 06 Mar 2009 18:47:00 -0000 From: Joel Brobecker To: Paul Pluzhnikov Cc: tromey@redhat.com, Pedro Alves , gdb-patches@sourceware.org Subject: Re: [patch] Fix a crash when displaying variables from shared library. Message-ID: <20090306184652.GK3744@adacore.com> References: <20090223010759.GA30997@adacore.com> <8ac60eac0902231012lb42bcb1q8b8cf19ad2ac192@mail.gmail.com> <8ac60eac0903021830w363783ear7d4c8fc1177d6448@mail.gmail.com> <8ac60eac0903041124s1aafb562u225f268c4d1511dd@mail.gmail.com> <20090305200415.GC3744@adacore.com> <8ac60eac0903051546r1eaffc89tf1f35b21e6dc1b40@mail.gmail.com> <8ac60eac0903051906r5d41990bwcaccdfb4accef562@mail.gmail.com> <20090306174822.GJ3744@adacore.com> <8ac60eac0903061031n82e758cp1b56bf374a3de838@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ac60eac0903061031n82e758cp1b56bf374a3de838@mail.gmail.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org X-SW-Source: 2009-03/txt/msg00085.txt.bz2 > Attached patch does that. Thanks! > I didn't touch similarly mis-named xcoff_solib_address, because I can't > see any use of that symbol. Perhaps it should be deleted? This function is actually used as a #define in config/rs6000/nm-rs6000.h: #define PC_SOLIB(PC) xcoff_solib_address(PC) I'll change its name when I have a moment. But perhaps the whole file could be modernized too. So let's leave it aside for now. > 2009-03-06 Paul Pluzhnikov > > Rename solib_address to solib_name_from_address. > * breakpoint.c (insert_bp_location, disable_breakpoints_in_shlibs) > (disable_breakpoints_in_unloaded_shlib): Update. > * printcmd.c (display_uses_solib_p): Likewise. > * stack.c (print_frame): Likewise. > * solib.c: Rename. > * solib.h: Rename. Looks great. Please apply. And thank you for taking care of this. -- Joel