From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1013 invoked by alias); 3 Mar 2009 23:36:17 -0000 Received: (qmail 1004 invoked by uid 22791); 3 Mar 2009 23:36:16 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 03 Mar 2009 23:36:10 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 8386A107D3; Tue, 3 Mar 2009 23:36:08 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 4AAE510781; Tue, 3 Mar 2009 23:36:08 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Lee9f-0004qs-BN; Tue, 03 Mar 2009 18:36:07 -0500 Date: Tue, 03 Mar 2009 23:36:00 -0000 From: Daniel Jacobowitz To: "Joseph S. Myers" Cc: Alan Modra , Peter Bergner , Thiago Jung Bauermann , Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch] Fix power7 ppc64 binaries loading Message-ID: <20090303233607.GA18631@caradoc.them.org> Mail-Followup-To: "Joseph S. Myers" , Alan Modra , Peter Bergner , Thiago Jung Bauermann , Jan Kratochvil , gdb-patches@sourceware.org References: <20090302210237.GA23798@host0.dyn.jankratochvil.net> <20090302212403.GA3473@caradoc.them.org> <20090302213340.GA7433@host0.dyn.jankratochvil.net> <1236111881.30573.61.camel@localhost.localdomain> <20090303203050.GA2551@caradoc.them.org> <1236113699.6800.61.camel@otta> <20090303231626.GB9491@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-03/txt/msg00043.txt.bz2 On Tue, Mar 03, 2009 at 11:30:27PM +0000, Joseph S. Myers wrote: > On Wed, 4 Mar 2009, Alan Modra wrote: > > > Google for E500 ABI. It should only be enabled when you are > > assembling for e500. I've committed the following to mainline > > and 2.19 branch. > > > > * config/tc-ppc.c (md_assemble): APUinfo only for e500. > > > - if (ppc_cpu & (PPC_OPCODE_SPE > > - | PPC_OPCODE_ISEL | PPC_OPCODE_EFS > > - | PPC_OPCODE_BRLOCK | PPC_OPCODE_PMR | PPC_OPCODE_CACHELCK > > - | PPC_OPCODE_RFMCI)) > > + if ((ppc_cpu & PPC_OPCODE_E500MC) != 0) > > Most e500 are not e500mc (indeed, e500mc is mostly like classic PowerPC at > the userspace level, not like e500). The check is right - I had to go look in the assembler option parsing to figure it out though, so might deserve a comment. -- Daniel Jacobowitz CodeSourcery