From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13681 invoked by alias); 27 Feb 2009 22:14:26 -0000 Received: (qmail 13672 invoked by uid 22791); 27 Feb 2009 22:14:26 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Feb 2009 22:14:20 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id DBCE8107F8; Fri, 27 Feb 2009 22:14:18 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 6EA4210577; Fri, 27 Feb 2009 22:14:18 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LdAyH-0005KQ-KY; Fri, 27 Feb 2009 17:14:17 -0500 Date: Sat, 28 Feb 2009 01:11:00 -0000 From: Daniel Jacobowitz To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Create src/gdb/common, move signals.c there. Message-ID: <20090227221417.GB12904@caradoc.them.org> Mail-Followup-To: Doug Evans , gdb-patches@sourceware.org References: <20090205215202.CE0251C7A1E@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090205215202.CE0251C7A1E@localhost> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00504.txt.bz2 On Thu, Feb 05, 2009 at 01:52:02PM -0800, Doug Evans wrote: > Some code is shared between gdb and gdbserver, and over time more > code will be shared. And I think the lack of explicit sharing > is complicating progress. I, personally, do not think that sharing code between gdb and gdbserver is very useful. There's no defined common API that shared code could rely on, and the internals are pretty different. > This patch does these things: > > 1) Create src/gdb/common, and adds -I's to $(src)/common to the Makefiles. > 2) Pull the duplicate decls of the functions in signals.c out of > gdb/target.h and gdbserver/server.h and put them in common/gdb_signals.h. > 3) Move signals/signals.c to common/signals.c, and cleans up signals.c > a bit. This patch seems fine on its own merits, though. > - maybe(!) move regformats to common, though it's big enough > and standalone enough that I don't have an opinion on it Not sure what the point of this would be, that code is just for gdbserver. -- Daniel Jacobowitz CodeSourcery