Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [RFA] Include thread ID in target_wait debugging output.
Date: Thu, 26 Feb 2009 19:22:00 -0000	[thread overview]
Message-ID: <20090226184107.B00611C78A7@localhost> (raw)

Hi.

Printing the result of target_wait when "set debug infrun 1" is great,
but I've found I've needed the thread ID.

The output line was getting a bit long, so I split it up.
There are other ways to split it up, but this works for me.

Ok to check in?

2009-02-26  Doug Evans  <dje@google.com>

	Include thread ID in target_wait debugging output.
	* infrun.c (print_target_wait_results): New function.
	(wait_for_inferior,fetch_inferior_event): Call it.

Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.360
diff -u -p -r1.360 infrun.c
--- infrun.c	25 Feb 2009 02:14:22 -0000	1.360
+++ infrun.c	26 Feb 2009 18:34:57 -0000
@@ -1737,6 +1737,30 @@ delete_step_thread_step_resume_breakpoin
   delete_step_thread_step_resume_breakpoint ();
 }
 
+/* Pretty print the results of target_wait, for debugging purposes.  */
+
+static void
+print_target_wait_results (ptid_t waiton_ptid, ptid_t result_ptid,
+			   const struct target_waitstatus *ws)
+{
+  char *status_string = target_waitstatus_to_string (ws);
+
+  fprintf_unfiltered (gdb_stdlog,
+		      "infrun: target_wait (%d", PIDGET (waiton_ptid));
+  if (PIDGET (waiton_ptid) != -1)
+    fprintf_unfiltered (gdb_stdlog,
+			" [%s]", target_pid_to_str (waiton_ptid));
+  fprintf_unfiltered (gdb_stdlog, ", status) =\n");
+  fprintf_unfiltered (gdb_stdlog,
+		      "infrun:   %d [%s],\n",
+		      PIDGET (result_ptid), target_pid_to_str (result_ptid));
+  fprintf_unfiltered (gdb_stdlog,
+		      "infrun:   %s\n",
+		      status_string);
+
+  xfree (status_string);
+}
+
 /* Wait for control to return from inferior to debugger.
 
    If TREAT_EXEC_AS_SIGTRAP is non-zero, then handle EXEC signals
@@ -1790,14 +1814,7 @@ wait_for_inferior (int treat_exec_as_sig
 	ecs->ptid = target_wait (waiton_ptid, &ecs->ws);
 
       if (debug_infrun)
-	{
-	  char *status_string = target_waitstatus_to_string (&ecs->ws);
-	  fprintf_unfiltered (gdb_stdlog,
-			      "infrun: target_wait (%d, status) = %d, %s\n",
-			      PIDGET (waiton_ptid), PIDGET (ecs->ptid),
-			      status_string);
-	  xfree (status_string);
-	}
+	print_target_wait_results (waiton_ptid, ecs->ptid, &ecs->ws);
 
       if (treat_exec_as_sigtrap && ecs->ws.kind == TARGET_WAITKIND_EXECD)
         {
@@ -1875,14 +1892,7 @@ fetch_inferior_event (void *client_data)
     ecs->ptid = target_wait (waiton_ptid, &ecs->ws);
 
   if (debug_infrun)
-    {
-      char *status_string = target_waitstatus_to_string (&ecs->ws);
-      fprintf_unfiltered (gdb_stdlog,
-			  "infrun: target_wait (%d, status) = %d, %s\n",
-			  PIDGET (waiton_ptid), PIDGET (ecs->ptid),
-			  status_string);
-      xfree (status_string);
-    }
+    print_target_wait_results (waiton_ptid, ecs->ptid, &ecs->ws);
 
   if (non_stop
       && ecs->ws.kind != TARGET_WAITKIND_IGNORE


             reply	other threads:[~2009-02-26 18:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-26 19:22 Doug Evans [this message]
2009-02-27 19:56 ` Pedro Alves
2009-02-27 21:13   ` Doug Evans
2009-02-27 22:11     ` Doug Evans
2009-02-27 22:14       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090226184107.B00611C78A7@localhost \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox