From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6550 invoked by alias); 24 Feb 2009 14:48:36 -0000 Received: (qmail 6542 invoked by uid 22791); 24 Feb 2009 14:48:36 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Feb 2009 14:48:28 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id D3CB1105BB; Tue, 24 Feb 2009 14:48:26 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id AAE811018B; Tue, 24 Feb 2009 14:48:26 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LbyaA-0001Ua-1Q; Tue, 24 Feb 2009 09:48:26 -0500 Date: Tue, 24 Feb 2009 14:57:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: teawater , Eli Zaretskii , "gdb-patches@sourceware.org" Subject: Re: [RFA] Add _() to query Message-ID: <20090224144826.GA5387@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , teawater , Eli Zaretskii , "gdb-patches@sourceware.org" References: <20090224133255.GA25107@caradoc.them.org> <20090224133929.GA30561@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090224133929.GA30561@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00462.txt.bz2 On Tue, Feb 24, 2009 at 02:39:29PM +0100, Jan Kratochvil wrote: > On Tue, 24 Feb 2009 14:32:55 +0100, Daniel Jacobowitz wrote: > > On Tue, Feb 24, 2009 at 03:10:51PM +0800, teawater wrote: > > > I remember you told me that you want to add _() to all query. > > > I make a patch for it. Do you think it's OK? > > > > Before this goes in, could someone see if we could use xgettext > > --keyword instead? That would let us translate messages in > > one place instead of all over. > > The standard for localized messages is _(). Making the localization more > magic makes the GDB project less viable for possible development newcomers. I have trouble believing that. I got this idea from GCC, which has used it for as long as I can remember. If you pass --keyword=query, and use N_() inside the body of query, xgettext will localize all arguments to query in the entire program. This is better for code size and for readability. -- Daniel Jacobowitz CodeSourcery