From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14927 invoked by alias); 23 Feb 2009 02:55:38 -0000 Received: (qmail 14919 invoked by uid 22791); 23 Feb 2009 02:55:37 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Feb 2009 02:55:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C7A682BAB5F; Sun, 22 Feb 2009 21:55:33 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7h--GXDud5+O; Sun, 22 Feb 2009 21:55:33 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 91F222BAB5E; Sun, 22 Feb 2009 21:55:33 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id EC866E7ACD; Sun, 22 Feb 2009 18:55:28 -0800 (PST) Date: Mon, 23 Feb 2009 03:13:00 -0000 From: Joel Brobecker To: Jay Cc: gdb-patches@sourceware.org Subject: Re: gdb 6.7.1 hppa64-hp-hpux11.11 "needs" _XOPEN_SOURCE_EXTENDED for various errors Message-ID: <20090223025528.GD26056@adacore.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00431.txt.bz2 Jay, It looks like you're on your way to send a collection of patches, which is great :). However, do you have a copyright assignment on file with the FSF? For a couple of small changes, we can accept them under the "Small change" / "obvious" rule, but past this, it is much better for you to have a copyright assignement. Your email address has a domain name of a university, so I have to direct your attention to ownership of the changes you are making if you are using the university's equipment to make the changes you are submitting. I think it's relatively uncommon for someone to have a pa-hpux machine at home (considering the size and price of these things). Anyway, sometimes, universities claim ownership of all work done using their equipment, so it becomes harder to submit them for inclusion in the FSF tree. I see that Cornell University has a copyright assignment for emacs, so the same might be needed for GDB. While you're at it, why not ask them if they would be willing to actually assign all changes for any GNU project? If you would like to start the process for getting your assignment filed with the FSF, please contact me privately, and I will be happy to get you started. This takes a little while, but do check with your university. Can I also ask you to have a look at the file gdb/CONTRIBUTE that explains a bit how to submit patches? For isntance, I noticed that your patches did not include a ChangeLog entry. In case of the problem at hand, I am afraid that your patch is not the best way of handling the problem. As a first measure, I think it's better to build with CFLAGS='-D_XOPEN_SOURCE_EXTENDED' when you call "make". I don't know much about this macro, and what its meaning is, I will double-check when I have a moment, but I wonder for instance if this macro should be defined if the HP/UX C compiler was used instead of GCC. Knowing more about this macro will allow us to implement a change in GDB's configure script that would allow a developer to build GDB without requiring this manual step. -- Joel