From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org,
Joel Brobecker <brobecker@adacore.com>,
Nick Roberts <nickrob@snap.net.nz>
Subject: Re: [PATCH] PR backtrace/9786
Date: Mon, 23 Feb 2009 02:08:00 -0000 [thread overview]
Message-ID: <20090223012156.GA7000@caradoc.them.org> (raw)
In-Reply-To: <200902230048.52805.pedro@codesourcery.com>
On Mon, Feb 23, 2009 at 12:48:52AM +0000, Pedro Alves wrote:
> This internal error sounds suspiciously related to the fact that
> there's no current way to distinguish a null/invalid frame id,
> from an outermost frame id... We should really fix that sometime.
I'd been holding off on this because there were all sorts of
less-hacky ways to do it, but maybe it's time for the hack:
replace the one null value with two magic null values. Use a
different one to represent the outermost frame than to represent no
frame.
This will still have some problems (all "outermost frames" will be
treated as equal) and require an audit of calls to frame_id_p (the
outermost frame should satisfy frame_id_p, that's the whole point, so
a different test will be needed to stop the backtrace). But it should
be a lot easier than an overhaul.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-02-23 1:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-22 19:37 Nick Roberts
2009-02-23 0:51 ` Joel Brobecker
2009-02-23 1:08 ` Pedro Alves
2009-02-23 2:08 ` Daniel Jacobowitz [this message]
2009-04-18 0:43 ` Nick Roberts
2009-04-20 17:19 ` Tom Tromey
2009-04-21 8:28 ` Nick Roberts
2009-06-23 18:39 ` Joel Brobecker
2009-06-23 18:46 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090223012156.GA7000@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=nickrob@snap.net.nz \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox