From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19860 invoked by alias); 17 Feb 2009 21:12:10 -0000 Received: (qmail 19851 invoked by uid 22791); 17 Feb 2009 21:12:09 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_13,J_CHICKENPOX_37 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Feb 2009 21:12:03 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id F1B2310701; Tue, 17 Feb 2009 21:12:00 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 94929106D8; Tue, 17 Feb 2009 21:12:00 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LZXEV-0006hR-GH; Tue, 17 Feb 2009 16:11:59 -0500 Date: Tue, 17 Feb 2009 21:37:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: Eli Zaretskii , gdb-patches@sources.redhat.com, nickrob@snap.net.nz Subject: Re: MI solib notification Message-ID: <20090217211159.GA25430@caradoc.them.org> Mail-Followup-To: Vladimir Prus , Eli Zaretskii , gdb-patches@sources.redhat.com, nickrob@snap.net.nz References: <200901310010.46738.vladimir@codesourcery.com> <200902172208.37427.vladimir@codesourcery.com> <200902172244.48437.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200902172244.48437.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00367.txt.bz2 On Tue, Feb 17, 2009 at 10:44:48PM +0300, Vladimir Prus wrote: > commit c1091d19fe7c4b02bb5ea623761e4caa0d6fe537 > Author: Vladimir Prus > Date: Fri Jan 30 20:50:50 2009 +0300 > > Implement MI notification for library loading/unloading > > gdb/doc/ > * gdb.texinfo (GDB/MI Async Records): Document the > =library-loaded and =library-unloaded notifications. > > gdb/ > * mi/mi-interp.c (mi_solib_loaded, mi_solib_unloaded): New. > (mi_interpreter_init): Register the above. > * solib.c (clear_solib): Notify solib unload. > * breakpoint.c (disable_breakpoints_in_unloaded_shlib): Do not > disable breakpoints on a.out targets. > > gdb/testsuite/ > * gdb.mi/mi-nonstop.exp (notifs): Adjust for library notifications. > * gdb.mi/mi-nsintrall.exp (notifs): Likewise. > * gdb.mi/mi-nsmoribund.exp (notifs): Likewise. > * lib/mi-support.exp (library_loaded_re): New. > (mi_run_cmd, mi_send_resuming_command_raw): Adjust. The code portions of this are OK now, thanks. > +static void mi_solib_loaded (struct so_list *solib) > +static void mi_solib_unloaded (struct so_list *solib) Newline after void please. -- Daniel Jacobowitz CodeSourcery