From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22028 invoked by alias); 15 Feb 2009 15:47:53 -0000 Received: (qmail 22020 invoked by uid 22791); 15 Feb 2009 15:47:53 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 15 Feb 2009 15:47:30 +0000 Received: (qmail 20884 invoked from network); 15 Feb 2009 15:40:17 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 15 Feb 2009 15:40:17 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFA] fix *stopped for CLI commands Date: Sun, 15 Feb 2009 18:22:00 -0000 User-Agent: KMail/1.9.10 Cc: Vladimir Prus References: <200902061045.18508.vladimir@codesourcery.com> <200902142222.31325.vladimir@codesourcery.com> In-Reply-To: <200902142222.31325.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902151547.28642.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00326.txt.bz2 Oops, I'm seeing this: Running ../../../src/gdb/testsuite/gdb.gdb/observer.exp ... FAIL: gdb.gdb/observer.exp: second observer attached; check second observer counter value FAIL: gdb.gdb/observer.exp: 1st observer added; check first observer counter value FAIL: gdb.gdb/observer.exp: 2nd observer added; check first observer counter value FAIL: gdb.gdb/observer.exp: 2nd observer added; check second observer counter value FAIL: gdb.gdb/observer.exp: 3rd observer added; check first observer counter value FAIL: gdb.gdb/observer.exp: 3rd observer added; check second observer counter value FAIL: gdb.gdb/observer.exp: 3rd observer added; check third observer counter value FAIL: gdb.gdb/observer.exp: 2nd observer removed; check first observer counter value FAIL: gdb.gdb/observer.exp: 2nd observer removed; check third observer counter value FAIL: gdb.gdb/observer.exp: 1st observer removed; check third observer counter value FAIL: gdb.gdb/observer.exp: three observers added; check first observer counter value FAIL: gdb.gdb/observer.exp: three observers added; check second observer counter value FAIL: gdb.gdb/observer.exp: three observers added; check third observer counter value FAIL: gdb.gdb/observer.exp: third observer removed; check first observer counter value FAIL: gdb.gdb/observer.exp: third observer removed; check second observer counter value FAIL: gdb.gdb/observer.exp: second observer removed; check first observer counter value Due to: (gdb) PASS: gdb.gdb/observer.exp: second observer attached; reset third observer counter call observer_notify_normal_stop (0) Too few arguments in function call. (gdb) PASS: gdb.gdb/observer.exp: second observer attached; sending notification (outch, that should have been a FAIL) The test needs to be adjusted to the new extra argument this notification takes. Alternatively, we could use a safer and more future proof test specific notification in doc/observer.texi, instead of reusing the normal_stop notification. Say, @deftypefun void test_notification (int @var{somearg}) For internal testing. Do not use. See testsuite/gdb.gdb/observer.exp. @end deftypefun -- Pedro Alves