From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29492 invoked by alias); 12 Feb 2009 13:22:59 -0000 Received: (qmail 29482 invoked by uid 22791); 12 Feb 2009 13:22:59 -0000 X-SWARE-Spam-Status: No, hits=0.6 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_13,KAM_STOCKTIP X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 Feb 2009 13:22:51 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 8C5E2107F8; Thu, 12 Feb 2009 13:22:48 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 5306E107F2; Thu, 12 Feb 2009 13:22:48 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LXbWh-0000oR-89; Thu, 12 Feb 2009 08:22:47 -0500 Date: Thu, 12 Feb 2009 13:22:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: Marc Khouzam , gdb-patches@sources.redhat.com, Nick Roberts Subject: Re: MI solib notification Message-ID: <20090212132247.GA3107@caradoc.them.org> Mail-Followup-To: Vladimir Prus , Marc Khouzam , gdb-patches@sources.redhat.com, Nick Roberts References: <200901310010.46738.vladimir@codesourcery.com> <20090201180423.GC4597@caradoc.them.org> <200902121212.53025.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200902121212.53025.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00281.txt.bz2 On Thu, Feb 12, 2009 at 12:12:52PM +0300, Vladimir Prus wrote: > Eclipse does use this, in particular consider this bit of code: > > public boolean hasSharedLibChanged(SharedLibrary lib, MIShared miLib) { > return !miLib.getName().equals(lib.getFileName()) || > !MIFormat.getBigInteger(miLib.getFrom()).equals(lib.getStartAddress()) || > !MIFormat.getBigInteger(miLib.getTo()).equals(lib.getEndAddress()) || > miLib.isRead() != lib.areSymbolsLoaded(); > } > > Now, we know this is never going to happen in practice, when using GDB, and this is > GDB-specific code, so maybe we can drop addresses from the GDB output and then DSF > folks will make sure they don't use start/end addresses? I see. This is code that parses the CLI output, right? Let's do as you suggest: not generate the addresses in MI notifications, and make GDB responsible for detecting this change in the future. > Well, not necessary, due to this code in clear_solib: > > > 903 if (exec_bfd != NULL > 904 && bfd_get_flavour (exec_bfd) != bfd_target_aout_flavour) > 905 disable_breakpoints_in_shlibs (); > > So, I think we'll only get additional chatter on a.out targets -- do we care? == vs != ? I think this runs everywhere except a.out. -- Daniel Jacobowitz CodeSourcery