Re: rawhide's gdb segfaults, w/patch

Jim Meyering
2009-01-10T09:52:12Z

Jan Kratochvil <jan.kratochvil@redhat.com> wrote:
> thanks but your patch needed a second part. It is a regression from:
> http://sourceware.org/ml/gdb-cvs/2008-04/msg00136.html
>
> On Sun, 28 Dec 2008 18:30:14 +0100, Jim Meyering wrote:
>> Here's an untested and quite possibly-wrong patch.
>> I.e., if the warning should be given even when "thisfun" is NULL,
>> it would have to be different.
>
> I find it right as gdbarch_return_value_ftype even has a comment:
> FUNCTYPE may be NULL in which case the return convention is computed based
> only on VALTYPE.
>
> This new argument and functype|func_type is only used in sh-tdep.c
> http://sourceware.org/ml/gdb-patches/2008-04/msg00277.html
> and even there it can be safely NULL.

Hi Jan,

Thanks for dealing with that!