From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11684 invoked by alias); 7 Feb 2009 14:56:09 -0000 Received: (qmail 11673 invoked by uid 22791); 7 Feb 2009 14:56:08 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 07 Feb 2009 14:56:04 +0000 Received: (qmail 17055 invoked from network); 7 Feb 2009 14:56:02 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 7 Feb 2009 14:56:02 -0000 From: Pedro Alves To: Paul Pluzhnikov Subject: Re: [3/2] Inspect extra signal information, handle amd64 bi-arch gdb Date: Sat, 07 Feb 2009 14:56:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: <200902031501.49657.pedro@codesourcery.com> <200902062337.19162.pedro@codesourcery.com> <8ac60eac0902061828r4e2c3f7dn6f2e5416950979c8@mail.gmail.com> In-Reply-To: <8ac60eac0902061828r4e2c3f7dn6f2e5416950979c8@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902071456.19344.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00178.txt.bz2 On Saturday 07 February 2009 02:28:44, Paul Pluzhnikov wrote: > On Fri, Feb 6, 2009 at 3:37 PM, Pedro Alves wrote: > This just broke my build :-( > > ../../src/gdb/linux-nat.c: In function 'linux_xfer_siginfo': > ../../src/gdb/linux-nat.c:3302: error: 'PTRACE_SETSIGINFO' undeclared > (first use in this function) > ../../src/gdb/linux-nat.c:3302: error: (Each undeclared identifier is > reported only once > ../../src/gdb/linux-nat.c:3302: error: for each function it appears in.) > make: *** [linux-nat.o] Error 1 > > I am targeting glibc-2.3.6, and that doesn't appear to have > PTRACE_SETSIGINFO > I've committed the below to fix it. gdbserver doesn't need fixing, as it's already doing this. According to grep over glibc 2.9, this value is good for all archs. -- Pedro Alves 2009-02-07 Pedro Alves * linux-nat.c (PTRACE_SETSIGINFO): Define if PTRACE_GETSIGINFO isn't defined. --- gdb/linux-nat.c | 1 + 1 file changed, 1 insertion(+) Index: src/gdb/linux-nat.c =================================================================== --- src.orig/gdb/linux-nat.c 2009-02-07 14:34:40.000000000 +0000 +++ src/gdb/linux-nat.c 2009-02-07 14:43:32.000000000 +0000 @@ -195,6 +195,7 @@ blocked. */ #ifndef PTRACE_GETSIGINFO #define PTRACE_GETSIGINFO 0x4202 +#define PTRACE_SETSIGINFO 0x4203 #endif /* The single-threaded native GNU/Linux target_ops. We save a pointer for