Re: [PATCH 4/4] catch syscall -- try 4 -- Build system, testcase and documentation

Eli Zaretskii
2009-01-26T04:02:11Z

> From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= <sergiodj@linux.vnet.ibm.com>
> Cc: teawater <teawater@gmail.com>
> Date: Sun, 25 Jan 2009 22:30:36 -0200
>
> At last but not least, the code for the build system, testcase and
> documentation parts.

Thanks.

> 2009-01-25 Sergio Durigan Junior <sergiodj@linux.vnet.ibm.com>
>
> * gdb.texinfo (catch syscall): Documentation about the new
> feature.

This is approved, with a few minor comments:

> +Catchpoint 1 (call to syscall 'chroot'), 0xffffe424 in __kernel_vsyscall ()

This line (and others similar to it) is too long for @smallexample, it
will certainly overflow the page margin. Please break these long
lines in two. The rule is to have at most 74 characters inside
@smallexample blocks.

> +If you configure @value{GDBN} using the @samp{--without-expat} option,
> +it will not be able to display syscall names. Also, if your
> +architecture does not have an XML file describing its system calls,
> +you will not be able to see the syscall names.

It would be good to add here a sentence saying that these two features
are used for accessing the syscall name database. It might be obvious
for you, but a Joe Random Hacker may not immediately realize that
catching syscalls has any relation to XML and expat.

What about a NEWS entry?