From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32588 invoked by alias); 1 Feb 2009 19:50:16 -0000 Received: (qmail 32579 invoked by uid 22791); 1 Feb 2009 19:50:16 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_23 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 01 Feb 2009 19:50:13 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 39624109AE; Sun, 1 Feb 2009 19:50:11 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 19652108C4; Sun, 1 Feb 2009 19:50:11 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LTiKY-00039Q-Nu; Sun, 01 Feb 2009 14:50:10 -0500 Date: Sun, 01 Feb 2009 19:50:00 -0000 From: Daniel Jacobowitz To: =?iso-8859-1?Q?S=E9rgio_Durigan_J=FAnior?= Cc: gdb-patches@sourceware.org, teawater Subject: Re: [PATCH 4/4] catch syscall -- try 4 -- Build system, testcase and documentation Message-ID: <20090201195010.GM4597@caradoc.them.org> Mail-Followup-To: =?iso-8859-1?Q?S=E9rgio_Durigan_J=FAnior?= , gdb-patches@sourceware.org, teawater References: <1232929837.26873.25.camel@miki> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1232929837.26873.25.camel@miki> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00013.txt.bz2 On Sun, Jan 25, 2009 at 10:30:36PM -0200, Sérgio Durigan Júnior wrote: > -HFILES_NO_SRCDIR = osf-share/cma_debug_client.h \ > +HFILES_NO_SRCDIR = osf-share/cma_debug_client.h linux-tdep.h \ Space there, not tab please. > @@ -844,11 +857,38 @@ generated_files = config.h observer.h observer.inc ada-lex.c \ > $(COMPILE) $< > $(POSTCOMPILE) > > -all: gdb$(EXEEXT) $(CONFIG_ALL) > +all: gdb$(EXEEXT) $(CONFIG_ALL) xml-syscall-copy > @$(MAKE) $(FLAGS_TO_PASS) DO=all "DODIRS=`echo $(SUBDIRS) | sed 's/testsuite//'`" subdir_do > .PHONY: all-tui > all-tui: $(TUI)$(EXEEXT) > > +xml-syscall-copy: > + if [ "`cd $(srcdir) && pwd`" != "`pwd`" ] ; then \ > + mkdir -p ./$(XML_SYSCALLS_DIR) ; \ > + list='$(XML_SYSCALLS_FILES)' ; \ > + for file in $$list ; do \ > + f=$(srcdir)/$(XML_SYSCALLS_DIR)/$$file ; \ > + if test -f $$f ; then \ > + $(INSTALL_DATA) $$f \ > + ./$(XML_SYSCALLS_DIR) ; \ > + fi ; \ > + done ; \ > + fi ; Why is this necessary? Is it for running GDB from the build directory? If that's it, please add a comment. Also, this and xml-syscall-install need a ".PHONY:" since they are not the names of real files. > +# Until "catch syscall" is implemented on other targets... > +if {![istarget "hppa*-hp-hpux*"] && ![istarget "*-linux*"]} then { > + continue > +} > + > +# This shall be updated whenever 'catch syscall' is implemented > +# on some architecture. > +#if { ![istarget "x86_64-*-linux*"] && ![istarget "i\[34567\]86-*-linux*"] > +if { ![istarget "i\[34567\]86-*-linux*"] > + && ![istarget "powerpc-*-linux*"] && ![istarget "powerpc64-*-linux*"] } { > + continue > +} Or you can test at runtime: if it prints out "not supported on this target yet" then issue an UNSUPPORTED and skip the rest of the test. -- Daniel Jacobowitz CodeSourcery