From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61393-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31961 invoked by alias); 1 Feb 2009 19:45:58 -0000
Received: (qmail 31951 invoked by uid 22791); 1 Feb 2009 19:45:58 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=AWL,BAYES_00,J_CHICKENPOX_27,J_CHICKENPOX_52
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 01 Feb 2009 19:45:54 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id 430C210815; 	Sun,  1 Feb 2009 19:45:52 +0000 (GMT)
Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) 	by nan.false.org (Postfix) with ESMTP id 26110107F4; 	Sun,  1 Feb 2009 19:45:52 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.69) 	(envelope-from <drow@caradoc.them.org>) 	id 1LTiGN-00034h-OL; Sun, 01 Feb 2009 14:45:51 -0500
Date: Sun, 01 Feb 2009 19:45:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: =?iso-8859-1?Q?S=E9rgio_Durigan_J=FAnior?= <sergiodj@linux.vnet.ibm.com>
Cc: Pierre Muller <muller@ics.u-strasbg.fr>, gdb-patches@sourceware.org, 	'teawater' <teawater@gmail.com>
Subject: Re: [PATCH 3/4] catch syscall -- try 4 -- XML support
Message-ID: <20090201194551.GL4597@caradoc.them.org>
Mail-Followup-To: =?iso-8859-1?Q?S=E9rgio_Durigan_J=FAnior?= <sergiodj@linux.vnet.ibm.com>, 	Pierre Muller <muller@ics.u-strasbg.fr>, gdb-patches@sourceware.org, 	'teawater' <teawater@gmail.com>
References: <1232929835.26873.24.camel@miki> <004901c97f90$c6019360$5204ba20$@u-strasbg.fr> <1233146315.26873.58.camel@miki>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1233146315.26873.58.camel@miki>
User-Agent: Mutt/1.5.17 (2008-05-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-02/txt/msg00012.txt.bz2

Pretty much OK.

On Wed, Jan 28, 2009 at 10:38:35AM -0200, Sérgio Durigan Júnior wrote:
> +<!-- The root element of a syscall info is <syscalls_info>.  -->
> +
> +<!ELEMENT syscalls_info		(syscall*)>

Sorry for the trouble, but please use "-" instead of "_".

> +<!-- Maybe the 'number' attribute will have to be changed from
> +     ID to CDATA.  -->
> +<!ELEMENT syscall		EMPTY>
> +<!ATTLIST syscall
> +	name			CDATA	#REQUIRED
> +	number			ID	#REQUIRED>

Yeah, just use CDATA.  Let's not mess with ID attributes; an ID of "1"
is not helpful if you want to embed this sort of document in another
one later.

> +<!ELEMENT xi:include	(EMPTY)>
> +<!ATTLIST xi:include
> +	xmlns:xi	CDATA	#FIXED "http://www.w3.org/2001/XInclude"
> +	href		CDATA	#REQUIRED>

Delete this; we don't need xi:include support for system call lists,
and you don't call xml_process_xincludes anyway.

> +/* Open FILENAME, read all its text into memory, close it, and return
> +   the text.  If something goes wrong, return NULL and warn.  */
> +
> +static char *
> +fetch_xml_from_file (const char *filename, void *baton)

Assuming this is identical to the one in xml-tdesc.c, give it a name
starting with xml and put it in xml-support.c instead please.

> +int
> +xml_number_of_syscalls (const struct syscalls_info *sysinfo)
> +{
> +  return (sysinfo == NULL ? 0 : VEC_length(syscall_desc_p,
> +                                           sysinfo->syscalls));
> +}

Space before paren.

-- 
Daniel Jacobowitz
CodeSourcery