From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: info frame ADDR internal error
Date: Sun, 01 Feb 2009 18:34:00 -0000 [thread overview]
Message-ID: <20090201183424.GG4597@caradoc.them.org> (raw)
In-Reply-To: <200901251944.32616.pedro@codesourcery.com>
On Sun, Jan 25, 2009 at 07:44:32PM +0000, Pedro Alves wrote:
> The new frame that create_new_frame created, isn't linked in the
> regular ( current_frame->... ) frame chain, it lives in its own chain,
> so this frame_find_by_id call isn't going to find it, unless you
> get lucky.
>
> This reinforces the bad things I was saying about create_new_frame.
>
> Any suggestions on how this could be fixed?
This is just gross. But yes, I see a way we could "fix" it. This
code is only reachable from select_frame and info frame. In the
former case, if we create a new frame we could clear the old frame
chain and set both current and selected frame to the new one;
in the latter case we'd have to clear the frame chain after info
frame was done, and restore the saved selected frame.
I do think this is somewhat useful, although being able to set
registers while debugging a core file would eliminate a lot of the
use...
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2009-02-01 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-25 16:34 Pedro Alves
2009-01-25 17:59 ` Daniel Jacobowitz
2009-01-25 19:43 ` Pedro Alves
2009-01-26 19:28 ` Pedro Alves
2009-02-01 18:34 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090201183424.GG4597@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox