From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26819 invoked by alias); 1 Feb 2009 18:28:43 -0000 Received: (qmail 26809 invoked by uid 22791); 1 Feb 2009 18:28:43 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_63 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 01 Feb 2009 18:28:36 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 8EB0F108AE; Sun, 1 Feb 2009 18:28:34 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 75BAB10815; Sun, 1 Feb 2009 18:28:34 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LTh3a-00021e-1O; Sun, 01 Feb 2009 13:28:34 -0500 Date: Sun, 01 Feb 2009 18:28:00 -0000 From: Daniel Jacobowitz To: Pierre Muller Cc: gdb-patches@sourceware.org Subject: Re: [RFC] Use untested for macscp.exp if no macro information generated Message-ID: <20090201182834.GE4597@caradoc.them.org> Mail-Followup-To: Pierre Muller , gdb-patches@sourceware.org References: <011801c92a03$4b71afa0$e2550ee0$@u-strasbg.fr> <001401c92af1$cf8821e0$6e9865a0$@u-strasbg.fr> <004a01c97f96$637bced0$2a736c70$@u-strasbg.fr> <000001c9814b$919b63a0$b4d22ae0$@u-strasbg.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000001c9814b$919b63a0$b4d22ae0$@u-strasbg.fr> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00005.txt.bz2 On Wed, Jan 28, 2009 at 02:23:11PM +0100, Pierre Muller wrote: > > I tried to simplify my patch for macro support > in order to get less uninteresting failures. I think your earlier patch had the right idea. Why did it leave some failures? We should have none if we're going to skip the test. > if {[list_and_check_macro main WHERE {macscp1.c {before macscp1_3}}]} { > - return 0 > + global verbose > + set macro_support "unknown" > + send_gdb "info source\n" > + gdb_expect 10 { General note, please use gdb_test_multiple. No need for a timeout in most cases; use the default setting. -- Daniel Jacobowitz CodeSourcery