From: Daniel Jacobowitz <drow@false.org>
To: Tom Tromey <tromey@redhat.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
Julian Brown <julian@codesourcery.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH/WIP] C/C++ wchar_t/Unicode printing support
Date: Sun, 01 Feb 2009 18:23:00 -0000 [thread overview]
Message-ID: <20090201182344.GD4597@caradoc.them.org> (raw)
In-Reply-To: <m3ocxos6og.fsf@fleche.redhat.com>
On Fri, Jan 30, 2009 at 04:41:35PM -0700, Tom Tromey wrote:
> Joel> Do you think we could have a configure option that allows us to
> Joel> deactivate this feature in order to avoid the dependency?
>
> I don't think it would be very easy to make this an optional feature,
> or to make it fall back to the currently existing code.
>
> I suppose one option would be to have a degraded mode where we require
> that the host charset and the target charset be the same. Then maybe
> we could make it work by redefining iswprint and wchar_t.
I don't see the connection between the iconv dependency and iswprint /
wchar_t. Are there portability issues for those too? They don't come
from libiconv.
It seems like a dummy version of iconv_open which only succeeds if the
two character sets are the same, plus a pass-through version of iconv,
would be enough to remove the iconv dependency. That degraded mode
covers all local debugging. There'd need to be a little additional
logic too, to allow you to set all the charset variables at once;
otherwise you'd be stuck since validate would fail when you tried to
change any of them. Or just remove the settings in that case.
> I don't think it would be very easy to preserve the current
> functionality and make the iconv stuff an add-on. The current charset
> API is not well suited to variable length encodings.
In my opinion, the current non-iconv, non-identity conversions
are not a major loss. But if someone was motivated to preserve them,
it seems like that wouldn't be hard; add them to the fallback
implementation of iconv.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-02-01 18:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 20:24 Julian Brown
2009-01-15 21:02 ` Tom Tromey
2009-01-15 21:18 ` Joseph S. Myers
2009-01-16 0:01 ` Tom Tromey
2009-01-15 22:16 ` Julian Brown
2009-01-16 0:53 ` Tom Tromey
2009-01-16 9:36 ` Eli Zaretskii
2009-01-16 16:18 ` Tom Tromey
2009-01-16 16:40 ` Eli Zaretskii
2009-01-16 16:57 ` Mark Kettenis
2009-01-30 4:11 ` Tom Tromey
2009-01-30 22:14 ` Joel Brobecker
[not found] ` <m3ocxos6og.fsf@fleche.redhat.com>
2009-02-01 18:23 ` Daniel Jacobowitz [this message]
2009-02-01 22:42 ` Tom Tromey
2009-02-01 23:16 ` Daniel Jacobowitz
2009-02-01 23:18 ` Daniel Jacobowitz
2009-02-01 23:26 ` Tom Tromey
2009-02-03 0:41 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090201182344.GD4597@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=julian@codesourcery.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox