From: Pedro Alves <pedro@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] amd64 displaced stepping support
Date: Wed, 28 Jan 2009 14:34:00 -0000 [thread overview]
Message-ID: <200901281332.59986.pedro@codesourcery.com> (raw)
In-Reply-To: <e394668d0901280039s4fc7e2ch460040bd09127770@mail.gmail.com>
On Wednesday 28 January 2009 08:39:47, Doug Evans wrote:
> I'd like to add the needed interfaces. I'm just not sure how long a
> process that will be and I'd like to get started on exercising amd64
> non-stop functionality. I'll pursue exporting the modrm_bytes arrays
> and insn-length computation with binutils.
Ok, thanks a lot. I don't think doing that should be a prerequisite
for this patch. I just wanted to know if it's in your radar, and in case
it was not, to have it recorded somewhere as a TODO item.
> Ok to check in?
Looks great to me.
> [Modulo I need to clear the opcode/i386.h additions with binutils.
> I'm not sure who to get approval from first.]
The gdb bits are approved. A suggestion: don't add the macros/defines you
were adding in opcode/i386.h just yet, but inline / add them in amd64-tdep.c,
and check in the gdb patch (pre-approved). Then, all the opcode changes
can be made on top, separately (and incrementally, if desired). Sounds
good to you?
--
Pedro Alves
next prev parent reply other threads:[~2009-01-28 13:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 1:33 Doug Evans
2009-01-27 8:26 ` Stan Shebs
2009-01-27 17:27 ` Pedro Alves
2009-01-28 12:39 ` Doug Evans
2009-01-28 14:34 ` Pedro Alves [this message]
2009-01-28 15:05 ` Daniel Jacobowitz
2009-01-27 20:27 ` Daniel Jacobowitz
2009-01-28 0:13 ` Doug Evans
2009-01-28 14:37 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901281332.59986.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox