From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31970 invoked by alias); 26 Jan 2009 17:50:51 -0000 Received: (qmail 31957 invoked by uid 22791); 26 Jan 2009 17:50:51 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Jan 2009 17:50:44 +0000 Received: (qmail 19758 invoked from network); 26 Jan 2009 17:50:42 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Jan 2009 17:50:42 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFC/RFA] -break-insert -d Date: Mon, 26 Jan 2009 18:47:00 -0000 User-Agent: KMail/1.9.10 Cc: Vladimir Prus , gdb-patches@sources.redhat.com, Nick Roberts , Marc Khouzam References: <200901261614.25050.vladimir@codesourcery.com> In-Reply-To: <200901261614.25050.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200901261751.38003.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00505.txt.bz2 On Monday 26 January 2009 13:14:24, Vladimir Prus wrote: > > Presently, the -break-insert command always creates enabled breakpoint. Marc has noticed > that in Eclipse, with non-stop mode, this case lead to races. Specifically, if a breakpoint > is disabled in UI, then Eclipse first inserts a breakpoint, and then makes it disabled. So, > there's a window when the breakpoint is inserted in the target. One possible solution is > to modify Eclipse to never insert disabled breakpoint in GDB. However, this special-casing > has to be done in every frontend, and GDB-side solution is better. The below patch implements > new -d option to the -break-insert command, which causes the newly created breakpoints to be > disabled. > > Is the breakpoint.c change OK. Looks fine to me. > Any comments on MI changes? -- Pedro Alves From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31686 invoked by alias); 26 Jan 2009 17:50:48 -0000 Received: (qmail 31678 invoked by uid 22791); 26 Jan 2009 17:50:48 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Jan 2009 17:50:44 +0000 Received: (qmail 19758 invoked from network); 26 Jan 2009 17:50:42 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 26 Jan 2009 17:50:42 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [RFC/RFA] -break-insert -d Date: Mon, 26 Jan 2009 17:50:00 -0000 User-Agent: KMail/1.9.10 Cc: Vladimir Prus , gdb-patches@sources.redhat.com, Nick Roberts , Marc Khouzam References: <200901261614.25050.vladimir@codesourcery.com> In-Reply-To: <200901261614.25050.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-ID: <200901261751.38003.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00504.txt.bz2 Message-ID: <20090126175000.1yksFJ4ktHqxCTU-462updJ16YkGQ8YKaffZN_r2WUY@z> On Monday 26 January 2009 13:14:24, Vladimir Prus wrote: > > Presently, the -break-insert command always creates enabled breakpoint. Marc has noticed > that in Eclipse, with non-stop mode, this case lead to races. Specifically, if a breakpoint > is disabled in UI, then Eclipse first inserts a breakpoint, and then makes it disabled. So, > there's a window when the breakpoint is inserted in the target. One possible solution is > to modify Eclipse to never insert disabled breakpoint in GDB. However, this special-casing > has to be done in every frontend, and GDB-side solution is better. The below patch implements > new -d option to the -break-insert command, which causes the newly created breakpoints to be > disabled. > > Is the breakpoint.c change OK. Looks fine to me. > Any comments on MI changes? -- Pedro Alves