From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61319-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27015 invoked by alias); 26 Jan 2009 00:51:57 -0000
Received: (qmail 27004 invoked by uid 22791); 26 Jan 2009 00:51:56 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Jan 2009 00:51:53 +0000
Received: (qmail 2901 invoked from network); 26 Jan 2009 00:51:51 -0000
Received: from unknown (HELO orlando.local) (pedro@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 26 Jan 2009 00:51:51 -0000
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] catch syscall -- try 4 -- Architecture-independent part
Date: Mon, 26 Jan 2009 00:51:00 -0000
User-Agent: KMail/1.9.10
Cc: =?iso-8859-1?q?S=E9rgio_Durigan_J=FAnior?= <sergiodj@linux.vnet.ibm.com>,  teawater <teawater@gmail.com>
References: <1232929831.26873.22.camel@miki>
In-Reply-To: <1232929831.26873.22.camel@miki>
MIME-Version: 1.0
Content-Type: text/plain;   charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <200901260053.06295.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-01/txt/msg00489.txt.bz2

One quick comment before bedtime :-),

On Monday 26 January 2009 00:30:31, S=E9rgio Durigan J=FAnior wrote:
> + =A0printf_filtered (_("\nCatchpoint %d ("), b->number);
> +
> + =A0if (last.kind =3D=3D TARGET_WAITKIND_SYSCALL_ENTRY)
> + =A0 =A0printf_filtered (_("call to "));
> + =A0else
> + =A0 =A0printf_filtered (_("returned from "));
> +
> + =A0printf_filtered (_("syscall "));
> +
> + =A0if (s.name =3D=3D NULL)
> + =A0 =A0printf_filtered (_("%d"), b->syscall_number);
> + =A0else
> + =A0 =A0printf_filtered (_("'%s'"), s.name);
> +  printf_filtered (_("), "));
> +

Could you please combine this into full sentences, please?  It
will be better for translation, and probably clearer to read.  Say:

  struct cleanup *old_chain;
  char *syscall_id;

  if (s.name =3D=3D NULL)
    syscall_id =3D xstrprintf ("%d", b->syscall_number);
  else
    syscall_id =3D xstrprintf ("'%s'", s.name);
   old_chain =3D make_cleanup (xfree, syscall_id);

  if (last.kind =3D=3D TARGET_WAITKIND_SYSCALL_ENTRY)
    printf_filtered (_("\nCatchpoint %d (call to syscall %s), "),
                     syscall_id);
  else
    printf_filtered (_("\nCatchpoint %d (returned from %s), "),
                     syscall_id);
  do_cleanups (old_chain);

--=20
Pedro Alves