From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Remove call to deprecated_update_frame_pc_hack from normal_stop
Date: Fri, 23 Jan 2009 21:07:00 -0000 [thread overview]
Message-ID: <20090123210719.GA19465@caradoc.them.org> (raw)
In-Reply-To: <200901232016.07213.pedro@codesourcery.com>
On Fri, Jan 23, 2009 at 08:16:06PM +0000, Pedro Alves wrote:
> Do you think there's still a case for having this around?
>
> We always decrement the PC first thing in handle_inferior_event,
> before reiniting the cache.
>
> Of all other cases I can think of that end up calling normal_stop,
> if we end up here without a call to reinit_frame_cache, this hack
> is wrong/insuficient anyway.
>
> While I'm at it, I can eliminate deprecated_update_frame_pc_hack
> and deprecated_update_frame_base_hack, by inlining them in their
> only caller left.
>
> Tested on x86_64-linux.
This is fine with me.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2009-01-23 21:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 20:15 Pedro Alves
2009-01-23 21:07 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090123210719.GA19465@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox