From: Daniel Jacobowitz <drow@false.org>
To: Jerome Guitton <guitton@adacore.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: Add support for --with-system-gdbinit
Date: Fri, 23 Jan 2009 17:42:00 -0000 [thread overview]
Message-ID: <20090123174220.GA6643@caradoc.them.org> (raw)
In-Reply-To: <20090121105348.GD148@adacore.com>
On Wed, Jan 21, 2009 at 11:53:48AM +0100, Jerome Guitton wrote:
> + if (!initialized)
> + {
> + struct stat homebuf, cwdbuf, s;
> + char *homedir, *relocated_sysgdbinit;
> +
> + if (stat (SYSTEM_GDBINIT, &s) == 0)
> + sysgdbinit = SYSTEM_GDBINIT;
What, if anything, does SYSTEM_GDBINIT get defined to when GDB is
configured with no special options?
> + if (homedir)
> + {
> + homeinit = xstrprintf ("%s/%s", homedir, gdbinit);
> + if (stat (homeinit, &homebuf) != 0)
> + homeinit = NULL;
> +
> + stat (homeinit, &homebuf);
> + }
You've got a bunch of memory leaks in this function; this is one of
them. homeinit is not freed if it does not exist.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-01-23 17:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 13:56 Daniel Jacobowitz
2009-01-14 19:39 ` Eli Zaretskii
2009-01-14 19:50 ` Daniel Jacobowitz
2009-01-14 20:22 ` Eli Zaretskii
2009-01-14 20:38 ` Daniel Jacobowitz
2009-01-14 21:55 ` Eli Zaretskii
2009-01-14 23:07 ` Daniel Jacobowitz
2009-01-15 4:10 ` Eli Zaretskii
2009-01-19 14:11 ` Jerome Guitton
2009-01-19 14:20 ` Daniel Jacobowitz
2009-01-19 18:40 ` Eli Zaretskii
2009-01-21 10:54 ` Jerome Guitton
2009-01-21 19:03 ` Eli Zaretskii
2009-01-23 17:24 ` Jerome Guitton
2009-01-23 22:55 ` Eli Zaretskii
2009-01-28 18:00 ` Jerome Guitton
2009-01-23 17:42 ` Daniel Jacobowitz [this message]
2009-01-26 9:12 ` Jerome Guitton
2009-01-26 14:59 ` Daniel Jacobowitz
2009-01-28 15:06 ` Jerome Guitton
2009-01-16 11:54 ` Jerome Guitton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090123174220.GA6643@caradoc.them.org \
--to=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=guitton@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox