From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15649 invoked by alias); 15 Jan 2009 00:17:31 -0000 Received: (qmail 15639 invoked by uid 22791); 15 Jan 2009 00:17:30 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Jan 2009 00:16:54 +0000 Received: from zps76.corp.google.com (zps76.corp.google.com [172.25.146.76]) by smtp-out.google.com with ESMTP id n0F0GqFM012656 for ; Wed, 14 Jan 2009 16:16:52 -0800 Received: from localhost (ruffy.corp.google.com [172.18.118.116]) by zps76.corp.google.com with ESMTP id n0F0GoWX019080 for ; Wed, 14 Jan 2009 16:16:50 -0800 Received: by localhost (Postfix, from userid 67641) id 1019B1C7A9A; Wed, 14 Jan 2009 16:16:50 -0800 (PST) To: gdb-patches@sourceware.org Subject: [RFA] Make some char *'s -> const char *'s. Message-Id: <20090115001650.1019B1C7A9A@localhost> Date: Thu, 15 Jan 2009 00:17:00 -0000 From: dje@google.com (Doug Evans) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00339.txt.bz2 Hi. I've had a need in another patch to have these parts use const char * instead of char*. It's good cleanup to do anyway. Ok to check in? 2009-01-14 Doug Evans * target.h (target_signal_to_string): Make return type const char *. (target_signal_to_name): Ditto. (target_signal_from_name): Make arg const char *. * thread-db.c (thread_db_err_str): Make return type const char *. * utils.c (perror_with_name): Make arg const char *. * infrun.c (sig_print_info): Update. * gdbserver/gdbreplay.c (perror_with_name): Make arg const char *. * gdbserver/server.h (target_signal_to_name): Make return type const char *. * signals/signals.c (signals): Make array and struct members const. (target_signal_to_string): Make return type const char *. (target_signal_to_name): Ditto. (target_signal_from_name): Make arg const char *. Index: infrun.c =================================================================== RCS file: /cvs/src/src/gdb/infrun.c,v retrieving revision 1.350 diff -u -p -u -p -r1.350 infrun.c --- infrun.c 7 Jan 2009 21:42:49 -0000 1.350 +++ infrun.c 14 Jan 2009 23:59:16 -0000 @@ -4464,7 +4464,7 @@ Signal Stop\tPrint\tPass to progr static void sig_print_info (enum target_signal oursig) { - char *name = target_signal_to_name (oursig); + const char *name = target_signal_to_name (oursig); int name_padding = 13 - strlen (name); if (name_padding <= 0) Index: target.h =================================================================== RCS file: /cvs/src/src/gdb/target.h,v retrieving revision 1.139 diff -u -p -u -p -r1.139 target.h --- target.h 3 Jan 2009 05:57:53 -0000 1.139 +++ target.h 14 Jan 2009 23:59:16 -0000 @@ -174,13 +174,13 @@ enum inferior_event_type }; /* Return the string for a signal. */ -extern char *target_signal_to_string (enum target_signal); +extern const char *target_signal_to_string (enum target_signal); /* Return the name (SIGHUP, etc.) for a signal. */ -extern char *target_signal_to_name (enum target_signal); +extern const char *target_signal_to_name (enum target_signal); /* Given a name (SIGHUP, etc.), return its signal. */ -enum target_signal target_signal_from_name (char *); +enum target_signal target_signal_from_name (const char *); /* Target objects which can be transfered using target_read, target_write, et cetera. */ Index: gdbserver/gdbreplay.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/gdbreplay.c,v retrieving revision 1.20 diff -u -p -u -p -r1.20 gdbreplay.c --- gdbserver/gdbreplay.c 6 Jan 2009 04:49:29 -0000 1.20 +++ gdbserver/gdbreplay.c 14 Jan 2009 23:59:16 -0000 @@ -131,7 +131,7 @@ strerror (DWORD error) Then return to command level. */ static void -perror_with_name (char *string) +perror_with_name (const char *string) { #ifndef STDC_HEADERS extern int errno; Index: gdbserver/server.h =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/server.h,v retrieving revision 1.49 diff -u -p -u -p -r1.49 server.h --- gdbserver/server.h 3 Jan 2009 05:57:57 -0000 1.49 +++ gdbserver/server.h 14 Jan 2009 23:59:16 -0000 @@ -269,14 +269,14 @@ void buffer_xml_printf (struct buffer *b enum target_signal target_signal_from_host (int hostsig); int target_signal_to_host_p (enum target_signal oursig); int target_signal_to_host (enum target_signal oursig); -char *target_signal_to_name (enum target_signal); +const char *target_signal_to_name (enum target_signal); /* Functions from utils.c */ void *xmalloc (size_t) ATTR_MALLOC; void *xcalloc (size_t, size_t) ATTR_MALLOC; char *xstrdup (const char *) ATTR_MALLOC; -void perror_with_name (char *string); +void perror_with_name (const char *string); void error (const char *string,...) ATTR_NORETURN ATTR_FORMAT (printf, 1, 2); void fatal (const char *string,...) ATTR_NORETURN ATTR_FORMAT (printf, 1, 2); void warning (const char *string,...) ATTR_FORMAT (printf, 1, 2); Index: gdbserver/thread-db.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/thread-db.c,v retrieving revision 1.17 diff -u -p -u -p -r1.17 thread-db.c --- gdbserver/thread-db.c 3 Jan 2009 05:57:57 -0000 1.17 +++ gdbserver/thread-db.c 14 Jan 2009 23:59:16 -0000 @@ -45,7 +45,7 @@ static td_thragent_t *thread_agent; static int find_one_thread (int); static int find_new_threads_callback (const td_thrhandle_t *th_p, void *data); -static char * +static const char * thread_db_err_str (td_err_e err) { static char buf[64]; Index: gdbserver/utils.c =================================================================== RCS file: /cvs/src/src/gdb/gdbserver/utils.c,v retrieving revision 1.16 diff -u -p -u -p -r1.16 utils.c --- gdbserver/utils.c 3 Jan 2009 05:57:57 -0000 1.16 +++ gdbserver/utils.c 14 Jan 2009 23:59:16 -0000 @@ -92,7 +92,7 @@ xstrdup (const char *s) Then return to command level. */ void -perror_with_name (char *string) +perror_with_name (const char *string) { const char *err; char *combined; Index: signals/signals.c =================================================================== RCS file: /cvs/src/src/gdb/signals/signals.c,v retrieving revision 1.19 diff -u -p -u -p -r1.19 signals.c --- signals/signals.c 3 Jan 2009 05:57:57 -0000 1.19 +++ signals/signals.c 14 Jan 2009 23:59:16 -0000 @@ -50,9 +50,9 @@ struct gdbarch; /* This table must match in order and size the signals in enum target_signal in src/include/gdb/signals.h. */ /* *INDENT-OFF* */ -static struct { - char *name; - char *string; +static const struct { + const char *name; + const char *string; } signals [] = { {"0", "Signal 0"}, @@ -219,7 +219,7 @@ static struct { /* Return the string for a signal. */ -char * +const char * target_signal_to_string (enum target_signal sig) { if ((int) sig >= TARGET_SIGNAL_FIRST && (int) sig <= TARGET_SIGNAL_LAST) @@ -229,7 +229,7 @@ target_signal_to_string (enum target_sig } /* Return the name for a signal. */ -char * +const char * target_signal_to_name (enum target_signal sig) { if ((int) sig >= TARGET_SIGNAL_FIRST && (int) sig <= TARGET_SIGNAL_LAST @@ -243,7 +243,7 @@ target_signal_to_name (enum target_signa /* Given a name, return its signal. */ enum target_signal -target_signal_from_name (char *name) +target_signal_from_name (const char *name) { enum target_signal sig;