From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20561 invoked by alias); 14 Jan 2009 03:42:48 -0000 Received: (qmail 20551 invoked by uid 22791); 14 Jan 2009 03:42:47 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 14 Jan 2009 03:42:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 762FC2A968F for ; Tue, 13 Jan 2009 22:42:10 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id sRjMZk-tE4MM for ; Tue, 13 Jan 2009 22:42:10 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id AFE822A967D for ; Tue, 13 Jan 2009 22:42:09 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id B01C3E7ACD; Wed, 14 Jan 2009 07:42:02 +0400 (RET) Date: Wed, 14 Jan 2009 03:42:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [RFA/windows] cast of address to DWORD warning (handle_unload_dll) Message-ID: <20090114034202.GF31296@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="ADZbWkCsHQ7r3kzd" Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00299.txt.bz2 --ADZbWkCsHQ7r3kzd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 907 Hi Chris, This is one last case of a conversion of an address to an integer type whose size doesn't match on Windows64. I missed this one previously because the sources used by AdaCore don't produce this error message[1]. Other than that, I verified that a clean checkout of the sources allow us to build GDB on Vista64 with no warning. What's left to do is to add the last necessary bits to allow this port to be built as a target only, and then announce the port in the NEWS file... 2009-11-14 Joel Brobecker * windows-nat.c (handle_unload_dll): Use host_address to string in order to print the base address of the DLL that was unloaded. This one is hard to test, because it's supposed to never happen. So I tested it by, ahem, visual inspection (I learnt that expression at my first job, where we were producing safety critical software). Thanks, -- Joel --ADZbWkCsHQ7r3kzd Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="handle_unload.diff" Content-length: 395 diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index 724c18f..43b3d3d 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -761,7 +761,8 @@ handle_unload_dll (void *dummy) return 1; } - error (_("Error: dll starting at 0x%lx not found."), (DWORD) lpBaseOfDll); + error (_("Error: dll starting at %s not found."), + host_address_to_string (lpBaseOfDll)); return 0; } --ADZbWkCsHQ7r3kzd--