From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26304 invoked by alias); 10 Jan 2009 16:51:18 -0000 Received: (qmail 26295 invoked by uid 22791); 10 Jan 2009 16:51:17 -0000 X-Spam-Check-By: sourceware.org Received: from pool-96-233-71-199.bstnma.fios.verizon.net (HELO cgf.cx) (96.233.71.199) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 10 Jan 2009 16:50:41 +0000 Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id 07C4013C028; Sat, 10 Jan 2009 11:50:32 -0500 (EST) Received: by ednor.cgf.cx (Postfix, from userid 201) id 075BA2B385; Sat, 10 Jan 2009 11:50:32 -0500 (EST) Date: Sat, 10 Jan 2009 16:51:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org, Joel Brobecker Subject: Re: [RFA/win32] move win32_xfer_shared_library to (new) win32-tdep... Message-ID: <20090110165031.GB24850@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org, Joel Brobecker References: <20090110090843.GB29274@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090110090843.GB29274@adacore.com> User-Agent: Mutt/1.5.16 (2007-06-09) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00233.txt.bz2 On Sat, Jan 10, 2009 at 01:08:43PM +0400, Joel Brobecker wrote: >Hello, > >This patch moves the win32_xfer_shared_library function to a file >that is not specific to the target CPU. I introduced win32-tdep, >to follow the naming scheme used by win32-nat, even though these >file can also work on 64bit windows. If this file can work on 64 bit windows then it seems like it should be renamed to something more generic rather than potentially duplicating the same code in two places. Should win32-nat.c just be renamed to windows-nat.c? (I assume that RMS will be happy to see the "win" part go away anyway) cgf