From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19344 invoked by alias); 8 Jan 2009 09:27:36 -0000 Received: (qmail 19335 invoked by uid 22791); 8 Jan 2009 09:27:35 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_50,J_CHICKENPOX_44 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 08 Jan 2009 09:27:31 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1003C2A9677; Thu, 8 Jan 2009 04:27:30 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id SEmfH0KPc4Pe; Thu, 8 Jan 2009 04:27:30 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8E9022A9675; Thu, 8 Jan 2009 04:27:29 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 7C812E7ACD; Thu, 8 Jan 2009 13:27:22 +0400 (RET) Date: Thu, 08 Jan 2009 09:27:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFA: fix PR 9350 Message-ID: <20090108092722.GO3664@adacore.com> References: <20090107083448.GJ3664@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00135.txt.bz2 > 2009-01-06 Tom Tromey > > PR breakpoints/9350: > * varobj.c (varobj_invalidate): Unconditionally free > all_rootvarobj. > * symfile.c (syms_from_objfile): Free local_addr when returning > normally. > * exec.c (exec_file_attach): Do cleanups before returning. > (exec_file_command): Likewise. > * corefile.c (reopen_exec_file): Do cleanups before returning. > * breakpoint.c (insert_breakpoint_locations): Do cleanups before > returning. > (do_vec_free): New function. > (update_global_location_list): Make a cleanup for old_locations. > Do cleanups before returning. Remove unused variable 'e'. > (find_condition_and_thread): Free result of parsing the > expression. > (print_it_typical): Do cleanups before returning. > (breakpoint_re_set_one): Always free sals.sals. Thanks, Tom. This is OK. I did noticed that a patch to value.c disappeared compared to the initial patch. But it looks like it's been taken care of already, so all is well. -- Joel