From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [RFA/win32] Avoid a couple of name collisions in win32-nat.c
Date: Wed, 07 Jan 2009 16:57:00 -0000 [thread overview]
Message-ID: <20090107165734.GD31906@ednor.casa.cgf.cx> (raw)
In-Reply-To: <20090107112422.GB1751@adacore.com>
On Wed, Jan 07, 2009 at 03:24:22PM +0400, Joel Brobecker wrote:
>This patch simply renames a couple of global variables that are pointers
>to routines imported from kernel32. The reason why they need to be
>renamed is that the names chosen were identical to the name in kernel32,
>and the declaration is clashing with the declaration in winbase.h.
>I followed the example of the routines imported in psapi.dll where
>the name is prefixed by psapi_.
>
>2009-01-07 Joel Brobecker <brobecker@adacore.com>
>
> * win32-nat.c (kernel32_DebugSetProcessKillOnExit): Renames
> DebugSetProcessKillOnExit. Update all uses in this file.
> (kernel32_DebugActiveProcessStop): Renames DebugActiveProcessStop.
> Update all uses in this file.
>
>Tested on x86-windows.
>
>OK to apply?
Ah, should have read further. I don't understand why this is now a
problem. What changed?
cgf
next prev parent reply other threads:[~2009-01-07 16:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 11:24 Joel Brobecker
2009-01-07 16:57 ` Christopher Faylor [this message]
2009-01-08 12:53 ` Joel Brobecker
2009-01-09 10:42 ` Joel Brobecker
2009-01-14 6:23 ` Joel Brobecker
2009-01-14 15:08 ` Christopher Faylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090107165734.GD31906@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@sourceware.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox