From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12748 invoked by alias); 5 Jan 2009 17:29:46 -0000 Received: (qmail 12740 invoked by uid 22791); 5 Jan 2009 17:29:46 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Jan 2009 17:29:42 +0000 Received: (qmail 4121 invoked from network); 5 Jan 2009 17:29:39 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Jan 2009 17:29:39 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, Tom Tromey Subject: Re: RFA: fix PR 9164 Date: Mon, 05 Jan 2009 17:29:00 -0000 User-Agent: KMail/1.9.10 References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200901051729.39325.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00027.txt.bz2 On Saturday 03 January 2009 21:19:53, Tom Tromey wrote: > +static void > +find_size_type (const struct builtin_type *builtin, > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0struct language_arch_info *= lai) > +{ > + =A0lai->size_type_symbol =3D "size_t"; > + > + =A0/* For the default, pick an unsigned integral type the same width as > + =A0 =A0 a data pointer, if possible. =A0If none match, use unsigned int= . =A0*/ > + =A0if (TYPE_LENGTH (builtin->builtin_unsigned_long) > + =A0 =A0 =A0=3D=3D TYPE_LENGTH (builtin->builtin_data_ptr)) > + =A0 =A0lai->size_type_default =3D builtin->builtin_unsigned_long; > + =A0else if (TYPE_LENGTH (builtin->builtin_unsigned_long_long)) > + =A0 =A0lai->size_type_default =3D builtin->builtin_unsigned_long_long; > + =A0else > + =A0 =A0lai->size_type_default =3D builtin->builtin_unsigned_int; > +} I think that m32c will need a hook here. I think that in some modes, size_= t will be 16-bit, but pointer width 24-bits. I wonder if the above shouldn't be a gdbarch method, that defaults to what you wrote. --=20 Pedro Alves