From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3528 invoked by alias); 28 Dec 2008 11:48:32 -0000 Received: (qmail 3520 invoked by uid 22791); 28 Dec 2008 11:48:32 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 28 Dec 2008 11:47:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 001312A96C2; Sun, 28 Dec 2008 06:47:48 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id sb12qW8xpiCH; Sun, 28 Dec 2008 06:47:48 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 03D232A96C0; Sun, 28 Dec 2008 06:47:48 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id A14F8E7ACD; Sun, 28 Dec 2008 15:17:19 +0400 (RET) Date: Sun, 28 Dec 2008 11:48:00 -0000 From: Joel Brobecker To: Emi SUZUKI Cc: gdb-patches@sourceware.org Subject: Re: Watchpoint on an unloaded shared library(1) Message-ID: <20081228111719.GC4216@adacore.com> References: <20081222032758.GA2835@adacore.com> <20081225.202730.01371998.emi-suzuki@tjsys.co.jp> <20081226061055.GA4216@adacore.com> <20081226.160820.01367812.emi-suzuki@tjsys.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081226.160820.01367812.emi-suzuki@tjsys.co.jp> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00419.txt.bz2 > > Not quite: As you can see, this part of the code deals with hardware > > *breakpoints*, not watchpoints. > > Shame on me... I've totally missed that :-( Believe me, I've done way worse and I am pretty sure it will happen to me again (we're only human after all). > 2008-12-26 Joel Brobecker > Emi Suzuki > > * breakpoint.c (do_enable_breakpoint): Use update_watchpoint for > watchpoints. Looks good (just a tiny tiny formatting adjustment - see below). However, you did not say whether you tested the change (meaning that you verified that it does not introduce any new failure in the GDB testsuite), and if you did, on which system. I just want to make sure the change was properly tested before it is checked in. > + struct gdb_exception e; > + TRY_CATCH (e, RETURN_MASK_ALL) Can you add an empty line between these two line. The style in GDB is to separate the local variable declarations from the rest of the code by an empty line. Thanks, -- Joel