Re: Watchpoint on an unloaded shared library(1)

Joel Brobecker
2008-12-28T11:48:32Z

> > Not quite: As you can see, this part of the code deals with hardware
> > *breakpoints*, not watchpoints.
>
> Shame on me... I've totally missed that :-(

Believe me, I've done way worse and I am pretty sure it will happen
to me again (we're only human after all).

> 2008-12-26 Joel Brobecker <brobecker@adacore.com>
> Emi Suzuki <emi-suzuki@tjsys.co.jp>
>
> * breakpoint.c (do_enable_breakpoint): Use update_watchpoint for
> watchpoints.

Looks good (just a tiny tiny formatting adjustment - see below).
However, you did not say whether you tested the change (meaning that
you verified that it does not introduce any new failure in the GDB
testsuite), and if you did, on which system. I just want to make
sure the change was properly tested before it is checked in.

> + struct gdb_exception e;
> + TRY_CATCH (e, RETURN_MASK_ALL)

Can you add an empty line between these two line. The style in GDB
is to separate the local variable declarations from the rest of
the code by an empty line.

Thanks,
--
Joel