Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix completion memory double-free
Date: Mon, 22 Dec 2008 04:35:00 -0000	[thread overview]
Message-ID: <20081222043502.GC25416@adacore.com> (raw)
In-Reply-To: <20081220005103.GA19202@host0.dyn.jankratochvil.net>

> 2008-12-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	Fix memory double-free.
> 	* completer.c (line_completion_function): Clear LIST after called xfree.

Approved.

> gdb/testsuite/
> 2008-12-20  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* gdb.base/completion.exp (Completing non-existing component): New test.

And approved.

I really wonder if the "sleep 1" is needed in this case. A 1sec sleeping
delay is a LOT of time :-(, particularly since we can't run more than
one testcase at a time.

Thanks for the fix!
-- 
Joel


  reply	other threads:[~2008-12-22  4:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-20  0:51 Jan Kratochvil
2008-12-22  4:35 ` Joel Brobecker [this message]
2008-12-22 13:25   ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081222043502.GC25416@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox