Re: [patch] Fix hw watchpoints regression on i386/x86_64/ia64

Jan Kratochvil
2008-12-21T19:04:40Z

On Sun, 21 Dec 2008 16:36:46 +0100, Daniel Jacobowitz wrote:
> On Sun, Dec 21, 2008 at 04:10:46PM +0100, Jan Kratochvil wrote:
> > > This test case should respect [target_info exists gdb,no_hardware_watchpoints].
> > ^<-also
> > as according to my test on ppc64 RHEL-4 gdb-6.3+kernel (both not supporting
> > ppc hw watchpoints) dejagnu-1.4.4 did not have `no_hardware_watchpoints' set.
>
> I suggest you use a custom board file which does set it.

Sorry I did commit it this way. Should I commit this one?

Regards,
Jan

2008-12-21 Jan Kratochvil <jan.kratochvil@redhat.com>

* gdb.base/watchpoint-hw.exp: Remove the limitation on specific arches.

--- gdb/testsuite/gdb.base/watchpoint-hw.exp 21 Dec 2008 15:01:32 -0000 1.1
+++ gdb/testsuite/gdb.base/watchpoint-hw.exp 21 Dec 2008 18:59:55 -0000
@@ -13,10 +13,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.

-# Arch not supporting hw watchpoints does not imply no_hardware_watchpoints set.
-if {(![istarget "i?86-*-*"] && ![istarget "x86_64-*-*"]
- && ![istarget "ia64-*-*"] && ![istarget "s390*-*-*"])
- || [target_info exists gdb,no_hardware_watchpoints]} then {
+if {[target_info exists gdb,no_hardware_watchpoints]} then {
verbose "Skipping watchpoint-hw test."
return
}