From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27398 invoked by alias); 21 Dec 2008 15:12:01 -0000 Received: (qmail 27388 invoked by uid 22791); 21 Dec 2008 15:12:00 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,KAM_MX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 21 Dec 2008 15:10:57 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mBLFAqoG013598; Sun, 21 Dec 2008 10:10:52 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mBLFApoR022557; Sun, 21 Dec 2008 10:10:51 -0500 Received: from host0.dyn.jankratochvil.net (sebastian-int.corp.redhat.com [172.16.52.221]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mBLFAmqX025592; Sun, 21 Dec 2008 10:10:49 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id mBLFAlDp005810; Sun, 21 Dec 2008 16:10:47 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.2/Submit) id mBLFAk6I005806; Sun, 21 Dec 2008 16:10:46 +0100 Date: Sun, 21 Dec 2008 15:12:00 -0000 From: Jan Kratochvil To: Ulrich Weigand Cc: gdb-patches@sourceware.org, Daniel Jacobowitz Subject: Re: [patch] Fix hw watchpoints regression on i386/x86_64/ia64 Message-ID: <20081221151046.GA9181@host0.dyn.jankratochvil.net> References: <20081208083759.GA18359@host0.dyn.jankratochvil.net> <200812172012.mBHKCDY5006031@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200812172012.mBHKCDY5006031@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00363.txt.bz2 On Wed, 17 Dec 2008 21:12:13 +0100, Ulrich Weigand wrote: > > + /* Hack around 'unused var' error for some targets here. */ > > + (void) i; > > Is this really necessary? The other callers of > TARGET_CAN_USE_HARDWARE_WATCHPOINT don't do that either ... It was a copy-paste from existing do_enable_breakpoint() (line 7799). But it got now removed according to your advice as: (1) The original code uses `i' and `mem_cnt' initialization in the declaration while my code initializes them explicitely which suppresses the `unused variable' GCC warning on gcc-4.3. (2) GDB already uses explicit `-Wno-unused' by default and it already has unused variables scattered around which is a scope of different patches. > > +if {![istarget "i?86-*-*"] && ![istarget "x86_64-*-*"] && ![istarget "ia64-*-*"] > > + && ![istarget "s390*-*-*"]} then { > > + verbose "Skipping watchpoint-hw test." > > + return > > +} > > This test case should respect [target_info exists gdb,no_hardware_watchpoints]. ^<-also as according to my test on ppc64 RHEL-4 gdb-6.3+kernel (both not supporting ppc hw watchpoints) dejagnu-1.4.4 did not have `no_hardware_watchpoints' set. Committed: http://sourceware.org/ml/gdb-cvs/2008-12/msg00098.html Thanks, Jan gdb/ 2008-12-21 Jan Kratochvil Fix hw watchpoints created before the inferior was started. * breakpoint.c (update_watchpoint): Convert the bp_watchpoint and bp_hardware_watchpoint types according to the current runtime state. gdb/testsuite/ 2008-12-21 Jan Kratochvil * gdb.base/watchpoint-hw.exp, gdb.base/watchpoint-hw.c: New. --- src/gdb/breakpoint.c 2008/12/08 13:27:38 1.365 +++ src/gdb/breakpoint.c 2008/12/21 15:01:31 1.366 @@ -891,6 +891,27 @@ b->val_valid = 1; } + /* Change the type of breakpoint between hardware assisted or an + ordinary watchpoint depending on the hardware support and free + hardware slots. REPARSE is set when the inferior is started. */ + if ((b->type == bp_watchpoint || b->type == bp_hardware_watchpoint) + && reparse) + { + int i, mem_cnt, target_resources_ok, other_type_used; + + i = hw_watchpoint_used_count (bp_hardware_watchpoint, + &other_type_used); + mem_cnt = can_use_hardware_watchpoint (val_chain); + + if (mem_cnt) + target_resources_ok = TARGET_CAN_USE_HARDWARE_WATCHPOINT + (bp_hardware_watchpoint, i + mem_cnt, other_type_used); + if (!mem_cnt || target_resources_ok <= 0) + b->type = bp_watchpoint; + else + b->type = bp_hardware_watchpoint; + } + /* Look at each value on the value chain. */ for (v = val_chain; v; v = next) { --- src/gdb/testsuite/gdb.base/watchpoint-hw.c +++ src/gdb/testsuite/gdb.base/watchpoint-hw.c 2008-12-21 15:02:14.633223000 +0000 @@ -0,0 +1,27 @@ +/* This testcase is part of GDB, the GNU debugger. + + Copyright 2008 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . + + Please email any bugs, comments, and/or additions to this file to: + bug-gdb@prep.ai.mit.edu */ + +int watchee; + +int +main (void) +{ + return 0; +} --- src/gdb/testsuite/gdb.base/watchpoint-hw.exp +++ src/gdb/testsuite/gdb.base/watchpoint-hw.exp 2008-12-21 15:02:15.747687000 +0000 @@ -0,0 +1,52 @@ +# Copyright 2008 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Arch not supporting hw watchpoints does not imply no_hardware_watchpoints set. +if {(![istarget "i?86-*-*"] && ![istarget "x86_64-*-*"] + && ![istarget "ia64-*-*"] && ![istarget "s390*-*-*"]) + || [target_info exists gdb,no_hardware_watchpoints]} then { + verbose "Skipping watchpoint-hw test." + return +} + +set testfile watchpoint-hw +set srcfile ${testfile}.c +set binfile ${objdir}/${subdir}/${testfile} +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } { + untested "Couldn't compile test program" + return -1 +} + +gdb_exit +gdb_start +gdb_reinitialize_dir $srcdir/$subdir +gdb_load ${binfile} + +# Create the watchpoint before the inferior gets started. Now the native CPU +# target is still not active and its `to_can_use_hw_breakpoint' is not +# installed, therefore only a software watchpoint gets created. + +gdb_test "watch watchee" "atchpoint 1: watchee" + +# `runto_main' or `runto main' would delete the watchpoint created above. + +if { [gdb_start_cmd] < 0 } { + untested start + return -1 +} +gdb_test "" "main .* at .*" "start" + +# Check it is really a `hw'-watchpoint. +gdb_test "info watchpoints" "1 *hw watchpoint .* watchee"