From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6926 invoked by alias); 20 Dec 2008 17:16:26 -0000 Received: (qmail 6918 invoked by uid 22791); 20 Dec 2008 17:16:26 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Dec 2008 17:15:30 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0530A10633; Sat, 20 Dec 2008 17:15:28 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id CD2141062D; Sat, 20 Dec 2008 17:15:27 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1LE5QE-0007yb-Eq; Sat, 20 Dec 2008 12:15:26 -0500 Date: Sat, 20 Dec 2008 17:16:00 -0000 From: Daniel Jacobowitz To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFA: add C++ alternate punctuators Message-ID: <20081220171526.GA30284@caradoc.them.org> Mail-Followup-To: Tom Tromey , gdb-patches@sourceware.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00359.txt.bz2 On Sat, Dec 20, 2008 at 08:57:28AM -0700, Tom Tromey wrote: > C++ has alternate spellings for some operators. This patch adds > support for them to the C lexer. > > Rather than add a bunch of new code to the switch, I followed the > comment's advice and used a table. Does anything performance sensitive use this lexer, or is that likely in the future? I suspect this version will be quite a lot slower; it has a string copy and a linear search. I expect the copy in cp-name-parser.c will be performance sensitive but I don't know about this one. -- Daniel Jacobowitz CodeSourcery