From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15109 invoked by alias); 17 Dec 2008 20:13:01 -0000 Received: (qmail 15101 invoked by uid 22791); 17 Dec 2008 20:13:00 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Dec 2008 20:12:17 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id mBHKCEwW404342 for ; Wed, 17 Dec 2008 20:12:14 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mBHKCE261949744 for ; Wed, 17 Dec 2008 21:12:14 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mBHKCDtI006034 for ; Wed, 17 Dec 2008 21:12:14 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id mBHKCDY5006031; Wed, 17 Dec 2008 21:12:13 +0100 Message-Id: <200812172012.mBHKCDY5006031@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 17 Dec 2008 21:12:13 +0100 Subject: Re: [patch] Fix hw watchpoints regression on i386/x86_64/ia64 To: jan.kratochvil@redhat.com (Jan Kratochvil) Date: Wed, 17 Dec 2008 20:13:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, drow@false.org (Daniel Jacobowitz) In-Reply-To: <20081208083759.GA18359@host0.dyn.jankratochvil.net> from "Jan Kratochvil" at Dec 08, 2008 09:37:59 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00318.txt.bz2 Jan Kratochvil wrote: > 2008-12-08 Jan Kratochvil > > Fix hw watchpoints created before the inferior was started. > * breakpoint.c (update_watchpoint): Convert the bp_watchpoint and > bp_hardware_watchpoint types according to the current runtime state. > > 2008-12-08 Jan Kratochvil > > * gdb.base/watchpoint-hw.exp, gdb.base/watchpoint-hw.c: New. This seems reasonable to me. One minor issue: > + /* Hack around 'unused var' error for some targets here. */ > + (void) i; Is this really necessary? The other callers of TARGET_CAN_USE_HARDWARE_WATCHPOINT don't do that either ... > +if {![istarget "i?86-*-*"] && ![istarget "x86_64-*-*"] && ![istarget "ia64-*-*"] > + && ![istarget "s390*-*-*"]} then { > + verbose "Skipping watchpoint-hw test." > + return > +} This test case should respect [target_info exists gdb,no_hardware_watchpoints]. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com