Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Christophe LYON <christophe.lyon@st.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] testsuite gdb.base/expand-psymtabs: ensure code is generated  for the expected source line
Date: Tue, 16 Dec 2008 06:29:00 -0000	[thread overview]
Message-ID: <20081216062835.GP6866@adacore.com> (raw)
In-Reply-To: <493D3C16.3010303@st.com>

> I propose the attached small patch to expand-psymtabs.c. The goal is to 
> make sure the compiler actually generates code and debug information for 
> the expected line. Currently, our compiler attaches code only to the 
> opening brace, hence causing the test to fail.

Does you compiler also attach the epilogue code to the opening brace
as well.  With GCC, the epilogue is attached to the closing brace,
and so breaking on the empty line causes the breakpoint to be inserted
at the beginning of the epilogue.

> 2008-12-08  Christophe Lyon  <christophe.lyon@st.com>
> 
> 	* gdb.base/expand-psymtabs.c: Insert code in foo so that the
> 	compiler actually generate code at the expected line number.

Seems harmless in any case, and in fact, the original version of
the testcase when submitted included a function call at this location.
The reason why it was removed was that it was calling an IO function,
which is a no-no if we can avoid it (so that the testcase can be run
on targets that do not provide these routines).

OK to check in.

-- 
Joel


  parent reply	other threads:[~2008-12-16  6:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-08 15:25 Christophe LYON
2008-12-10 17:29 ` Carlos Eduardo Seo
2008-12-11  8:50   ` Christophe LYON
2008-12-15 12:02   ` Christophe LYON
2008-12-16  6:29 ` Joel Brobecker [this message]
2008-12-16 10:28   ` Christophe LYON
2008-12-16 13:19     ` Denis PILAT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081216062835.GP6866@adacore.com \
    --to=brobecker@adacore.com \
    --cc=christophe.lyon@st.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox