Re: Use of target_activity_function/target_activity_fd

[Pedro Alves <pedro@codesourcery.com>]

On Thursday 11 December 2008 13:31:36, Tristan Gingold wrote:
> Hi,
> 
> the hook target_activity_function is unused according to grep.  Is it  
> expected or should this unused code
> be removed ?

I've wondered this myself before.  It was added in 94,

Thu May 19 09:56:20 1994  Jim Kingdon  (kingdon@lioth.cygnus.com)

        * target.c, target.h: New variables target_activity_function and
        target_activity_fd.
        * inflow.c, inferior.h: New functions set_sigio_trap and
        clear_sigio_trap.
        * inftarg.c (child_wait), procfs.c (wait_fd): Call them.

This was added between GDB 4.9 and 5.0.  I don't think code setting
a target_activity_function has ever made it the the public GDB, at least
according to the ChangeLog.  5.0 doesn't have any either, so maybe this
was for some Cygnus customer project; maybe someone that worked
there at the time remembers it.  Insight also doesn't make use of it.

In any case, given that at least two people have lost time trying
to understand what good was this for, I say we nuke it,  and get rid
of *_sigio_trap in the process as well, which has calls that have been
propagated to several targets by now.

-- 
Pedro Alves