From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2090 invoked by alias); 5 Dec 2008 02:14:12 -0000 Received: (qmail 2074 invoked by uid 22791); 5 Dec 2008 02:14:11 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 05 Dec 2008 02:13:26 +0000 Received: (qmail 29826 invoked from network); 5 Dec 2008 02:12:59 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Dec 2008 02:12:59 -0000 From: Pedro Alves To: Doug Evans Subject: Re: Get rid of stop_pc (was: [RFA] dummy frame handling cleanup, plus inferior fun call signal handling improvement) Date: Fri, 05 Dec 2008 02:14:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org, Ulrich Weigand References: <200812050018.mB50I05V031478@d12av02.megacenter.de.ibm.com> <200812050115.30692.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_14IOJvwvG1C5Mnn" Message-Id: <200812050213.09380.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00088.txt.bz2 --Boundary-00=_14IOJvwvG1C5Mnn Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 358 On Friday 05 December 2008 01:49:02, Doug Evans wrote: > Nit. > > The check for !frame isn't related to removing stop_pc. Separate > patch or add a changelog entry? Oops, sorry. That is dead code. There is always a frame nowadays. get_current_frame either returns a frame, or throws --- never returns NULL. I've checked in the below. -- Pedro Alves --Boundary-00=_14IOJvwvG1C5Mnn Content-Type: text/x-diff; charset="iso 8859-15"; name="no_frame_core_dump.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="no_frame_core_dump.diff" Content-length: 665 2008-12-05 Pedro Alves * infcmd.c (step_once): Remove dead code. --- gdb/infcmd.c | 2 -- 1 file changed, 2 deletions(-) Index: src/gdb/infcmd.c =================================================================== --- src.orig/gdb/infcmd.c 2008-12-05 01:57:41.000000000 +0000 +++ src/gdb/infcmd.c 2008-12-05 02:00:17.000000000 +0000 @@ -928,8 +928,6 @@ step_once (int skip_subroutines, int sin clear_proceed_status (); frame = get_current_frame (); - if (!frame) /* Avoid coredump here. Why tho? */ - error (_("No current frame")); tp->step_frame_id = get_frame_id (frame); if (!single_inst) --Boundary-00=_14IOJvwvG1C5Mnn--