Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [RFA] Remove redundant resetting of stepping_past_singlestep_breakpoint
Date: Tue, 02 Dec 2008 04:32:00 -0000	[thread overview]
Message-ID: <20081202043154.D72E81C7A0B@localhost> (raw)

Hi.  While researching my prepare_to_proceed problem, I found this
in handle_inferior_event.

Just above this line:

  stepping_past_singlestep_breakpoint = 0;

there's this:

  if (stepping_past_singlestep_breakpoint)
    {
      gdb_assert (singlestep_breakpoints_inserted_p);
      gdb_assert (ptid_equal (singlestep_ptid, ecs->ptid));
      gdb_assert (!ptid_equal (singlestep_ptid, saved_singlestep_ptid));

      stepping_past_singlestep_breakpoint = 0;


Ok to check in?

2008-12-01  Doug Evans  <dje@google.com>

	* infrun.c (handle_inferior_event): Remove redundant resetting of
	stepping_past_singlestep_breakpoint.

Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.342
diff -u -p -r1.342 infrun.c
--- infrun.c	22 Nov 2008 04:41:45 -0000	1.342
+++ infrun.c	2 Dec 2008 04:13:24 -0000
@@ -2511,8 +2525,6 @@ targets should add new threads to the th
 	}
     }
 
-  stepping_past_singlestep_breakpoint = 0;
-
   if (!ptid_equal (deferred_step_ptid, null_ptid))
     {
       /* In non-stop mode, there's never a deferred_step_ptid set.  */


---

Alternatively, one might prefer this patch, which still preserves the
indication that stepping_past_singlestep_breakpoint is 0 at this point
but in a clearer form (no redundancy).

2008-12-01  Doug Evans  <dje@google.com>

	* infrun.c (handle_inferior_event): Replace redundant resetting of
	stepping_past_singlestep_breakpoint with an assert.

Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.342
diff -u -p -r1.342 infrun.c
--- infrun.c	22 Nov 2008 04:41:45 -0000	1.342
+++ infrun.c	2 Dec 2008 04:20:08 -0000
@@ -2511,7 +2525,7 @@ targets should add new threads to the th
 	}
     }
 
-  stepping_past_singlestep_breakpoint = 0;
+  gdb_assert (stepping_past_singlestep_breakpoint == 0);
 
   if (!ptid_equal (deferred_step_ptid, null_ptid))
     {


             reply	other threads:[~2008-12-02  4:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-02  4:32 Doug Evans [this message]
2008-12-02 16:05 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081202043154.D72E81C7A0B@localhost \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox