From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-60298-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 28490 invoked by alias); 25 Nov 2008 11:49:12 -0000
Received: (qmail 28481 invoked by uid 22791); 25 Nov 2008 11:49:12 -0000
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (212.99.106.210)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 25 Nov 2008 11:48:36 +0000
Received: from localhost (localhost [127.0.0.1]) 	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 8DD02290006; 	Tue, 25 Nov 2008 12:48:26 +0100 (CET)
Received: from mel.act-europe.fr ([127.0.0.1]) 	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) 	with ESMTP id pLMZVy+do0VL; Tue, 25 Nov 2008 12:48:25 +0100 (CET)
Received: from province.act-europe.fr (province.act-europe.fr [10.10.0.214]) 	by mel.act-europe.fr (Postfix) with ESMTP id CFE45290005; 	Tue, 25 Nov 2008 12:48:25 +0100 (CET)
Received: by province.act-europe.fr (Postfix, from userid 560) 	id BFA3516571E; Tue, 25 Nov 2008 12:48:25 +0100 (CET)
Date: Tue, 25 Nov 2008 18:38:00 -0000
From: Jerome Guitton <guitton@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: move value_from_contents_and_address to value.c
Message-ID: <20081125114825.GB55817@adacore.com>
References: <m3skplevf4.fsf@fleche.redhat.com> <20081125114306.GA55817@adacore.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081125114306.GA55817@adacore.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00689.txt.bz2

Jerome Guitton (guitton@adacore.com):

> By the way, I think there is a bug in the way we implemented it in
> ada-lang.c.  If I read the code correctly,
> value_from_contents_and_address returns a not_lval lazy value when
> valaddr is null. Not sure what we were trying to do, but this is
> certainly wrong... I'll have a look.

I meant: "when valaddr is null *and* address is 0".

Anyway, this can be fixed after of your changes.  I'll take care of
it.