From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10266 invoked by alias); 24 Nov 2008 23:08:26 -0000 Received: (qmail 10205 invoked by uid 22791); 24 Nov 2008 23:08:25 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Nov 2008 23:07:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 0B5282A9670; Mon, 24 Nov 2008 18:07:37 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id fw8D4+I1Xz0O; Mon, 24 Nov 2008 18:07:36 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C72572A9674; Mon, 24 Nov 2008 18:07:36 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 535D8E7ACD; Mon, 24 Nov 2008 15:07:34 -0800 (PST) Date: Tue, 25 Nov 2008 11:49:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFA: move value_from_contents_and_address to value.c Message-ID: <20081124230734.GB3946@adacore.com> References: <20081122050546.GB4318@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00675.txt.bz2 > 2008-11-24 Tom Tromey > > * ada-lang.c (value_from_contents_and_address): Move... > * value.c: ... here. > * ada-lang.h (value_from_contents_and_address): Move > declaration... > * value.h: ... here. Looks great to me. Just one tiny little remark, and I know it's our fault (at AdaCore). If you can fix it before checking in, then great. Otherwise, I can do it after you've checked the change in. > +struct value * > +value_from_contents_and_address (struct type *type, > + const gdb_byte *valaddr, > + CORE_ADDR address) There is a formatting issue in the third line, due to the use of spaces instead of tabs. I try to be super careful, now, but I can't seem to be able to find a convenient way of configuring my editor (vim) for that. > +extern struct value *value_from_contents_and_address (struct type *, > + const gdb_byte *, > + CORE_ADDR); Same here. Thanks! -- Joel