From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3423 invoked by alias); 24 Nov 2008 19:42:09 -0000 Received: (qmail 3356 invoked by uid 22791); 24 Nov 2008 19:42:08 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Nov 2008 19:41:27 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id A3B6F10D50; Mon, 24 Nov 2008 19:41:16 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 64CC510AD3; Mon, 24 Nov 2008 19:41:16 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1L4hJ4-0008On-VT; Mon, 24 Nov 2008 14:41:15 -0500 Date: Mon, 24 Nov 2008 22:11:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] -list-target-groups --available Message-ID: <20081124194114.GA31602@caradoc.them.org> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200811142003.33600.vladimir@codesourcery.com> <20081120144226.GA9855@caradoc.them.org> <200811221938.51061.vladimir@codesourcery.com> <200811221939.41982.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200811221939.41982.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00659.txt.bz2 On Sat, Nov 22, 2008 at 07:39:41PM +0300, Vladimir Prus wrote: > > This version has DTD. It also has documentation -- Eli, can you review it. > > I did you found a good place where new "info os processes" should be documented, > > any suggestions? In addition to the new info commands, there's also a new set remote command to control use of the packet; the new packet; and the new qSupported response. All of these need documentation. Sorry, back to you :-( > +@node Operating System Information > +@appendix Operating System Information > +@cindex operating system information > + > +Users of @value{GDBN} often wish to obtain information about state of about the state > +the operating system running on the target---for example the list of > +processes, or the list open files. This section describes the list of open files > +mechanism that makes it possible. This mechanism is similar to the > +target features mechanism (@pxref{Target Descriptions}), but focuses > +on different aspect of target. on a different > +Operating system information is retrived from the target via the > +remote protocol, using @samp{qXfer} requests (@pxref{General Query Packets, > +qXfer}). The object name in the request should be @samp{osdata}, and > +the @var{annex} identifies the data to be fetched. You can add an anchor to the new packet when it's documented and use that here; iirc that's already done for some qXfer packets. > +@node Process list > +@section Process list > +@cindex operating system information, process list > + > +When requesting process list, the @var{annex} field in the requesting the process list > +@samp{qXfer} request should be @samp{processes}. The returned data is > +an XML document. The formal syntax of this document is defined in > +@file{gdb/features/gdb-target.dtd}. Wrong DTD. > +The example content is: Not sure - "An example document is"? > +@smallexample > + > + Wrong DTD again. > + It's not . Also there's no version - you should probably add one, like done for the existing target description DTD (). > diff --git a/gdb/testsuite/gdb.server/ext-run.exp b/gdb/testsuite/gdb.server/ext-run.exp > index 5af5611..24ed5dd 100644 > --- a/gdb/testsuite/gdb.server/ext-run.exp > +++ b/gdb/testsuite/gdb.server/ext-run.exp > @@ -44,5 +44,11 @@ gdb_test "set remote exec-file $target_exec" "" "set remote exec-file" > gdb_breakpoint main > gdb_test "run" "Breakpoint.* main .*" "continue to main" > > +if { [istarget *-*-linux*] } { > + # On Linux, gdbserver can also report the list of processes. > +# 1 +root +/sbin/init\n.* > + gdb_test "info os processes" ".*pid +user +command.*1 +root +/sbin/init.*" "get process list" > +} Stray commented line? Testcase looks fine otherwise. -- Daniel Jacobowitz CodeSourcery