From: Pedro Alves <pedro@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Fix gdbserver vRun parsing again
Date: Mon, 24 Nov 2008 20:11:00 -0000 [thread overview]
Message-ID: <200811241759.37123.pedro@codesourcery.com> (raw)
In-Reply-To: <20081124173135.GA9091@caradoc.them.org>
On Monday 24 November 2008 17:31:35, Daniel Jacobowitz wrote:
> As part of closing PR 2474, I took another look at Pedro's fix last
> month to vRun. I approved it at the time but now I can see that he
> and I were both a little confused about the documented semantics :-(
> With Pedro's patch, "target extended-remote", "run one", "run two"
> will never run the program with argv[1] == "two". We're always
> supposed to use the new argv. "vRun;" means "old program, no args";
> "vRun;;XXXX" means "old program, decoded arg XXXX".
>
Oh, very sorry about that. I should have sticked to fixing
the crash. :-(
> This patch seems to do the right thing; Pedro, want to take a look at
> this obviously tricky code before I change it?
I tried it out, and it does do the right thing, and I
also confirmed the original crash isn't reintroduced.
Thanks.
--
Pedro Alves
next prev parent reply other threads:[~2008-11-24 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 20:11 Daniel Jacobowitz
2008-11-24 20:11 ` Pedro Alves [this message]
2008-11-24 20:11 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811241759.37123.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox