From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-60257-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27412 invoked by alias); 24 Nov 2008 16:50:55 -0000
Received: (qmail 27341 invoked by uid 22791); 24 Nov 2008 16:50:54 -0000
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Nov 2008 16:50:14 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id 7250810D50; 	Mon, 24 Nov 2008 16:50:04 +0000 (GMT)
Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) 	by nan.false.org (Postfix) with ESMTP id 5DF0A10AD3; 	Mon, 24 Nov 2008 16:50:04 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.69) 	(envelope-from <drow@caradoc.them.org>) 	id 1L4edP-0001YO-II; Mon, 24 Nov 2008 11:50:03 -0500
Date: Mon, 24 Nov 2008 20:08:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Tom Tromey <tromey@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix completer access of an already freed memory
Message-ID: <20081124165003.GA5922@caradoc.them.org>
Mail-Followup-To: Tom Tromey <tromey@redhat.com>, 	Jan Kratochvil <jan.kratochvil@redhat.com>, 	gdb-patches@sourceware.org
References: <20081122231304.GA12471@host0.dyn.jankratochvil.net> <m31vx13wzt.fsf@fleche.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m31vx13wzt.fsf@fleche.redhat.com>
User-Agent: Mutt/1.5.17 (2008-05-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-11/txt/msg00648.txt.bz2

On Mon, Nov 24, 2008 at 09:32:54AM -0700, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> 2008-11-22  Jan Kratochvil  <jan.kratochvil@redhat.com>
> Jan> 	Fix access of an already freed memory.
> Jan> 	* parse.c (parse_field_expression): Call xstrdup on `*name'.
> Jan> 	* completer.c (expression_completer): Free fieldname.
> 
> Thanks.  FWIW, this looks reasonable to me.  I can't approve it though.

Good enough for me - this is OK, thanks.

-- 
Daniel Jacobowitz
CodeSourcery