From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28007 invoked by alias); 20 Nov 2008 19:15:40 -0000 Received: (qmail 27977 invoked by uid 22791); 20 Nov 2008 19:15:40 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Nov 2008 19:14:59 +0000 Received: (qmail 2994 invoked from network); 20 Nov 2008 19:14:57 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Nov 2008 19:14:57 -0000 From: Pedro Alves To: "Ulrich Weigand" Subject: Re: Fix foll-fork.exp foll-vfork.exp fork-child-threads.exp Date: Fri, 21 Nov 2008 12:58:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: <200811201824.mAKIORtZ014998@d12av02.megacenter.de.ibm.com> In-Reply-To: <200811201824.mAKIORtZ014998@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811201915.07670.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00567.txt.bz2 On Thursday 20 November 2008 18:24:27, Ulrich Weigand wrote: > However, even given that we need to do it in "resume" -- why so late > in resume, after e.g. displaced stepping or software single-step > was already set up? For example, isn't singlestep_ptid set to the > wrong value if we later decide to follow the child? > > It seems to me it would make more sense to have that decision come > *first* -- and then we could use the correct thread_info and regcache > etc. pointers throughout. I guess there may have been a good reason > to place the call where it is, but I don't see it off-hand ... Hmmm, right, good point. I agree. -- Pedro Alves